WineHQ
Wine source repository – Patch status
IDStatusAuthorSubjectReviewerSignTestbotJob ID
135147NewAndrew Wesie[v2 3/3] user32/tests: Add test for GetWindowDisplayAffinity.
135146NewAndrew Wesie[3/3] user32/tests: Add test for GetWindowDisplayAffinity.Failed31812
135145NewAndrew Wesie[2/3] user32: Implement GetWindowDisplayAffinity.
135144NewAndrew Wesie[1/3] server: Add field for window display affinity.
135143NewVincent PovirkRe: [PATCH] gdiplus: Write API for GdipAddPathLine and GdipAddPathLineI
135142NewVincent PovirkRe: [PATCH] gdiplus: Write API for GdipClonePath
135141NewVincent PovirkRe: [PATCH] gdiplus: Write API doc for GdipAddPathEllipse and GdipAddPathEllipseIX
135140NewZebediah Figura[PATCH 2/2] tools/winedbg: Add support for printing SSE (XMM) registers.
135139NewZebediah Figura[PATCH 1/2] tools/winedbg: Add support for printing floating point registers.
135138NewVincent PovirkRe: [PATCH] gdiplus: Write API documentation for GdipAddPathArc and GdipAddPathArcI
135137NewVincent PovirkRe: [4/7] windowscodecs: Implement IWICBitmapDecoder::GetMetadataQueryReader in the GIF decoder.
135136NewVincent PovirkRe: [3/7] windowscodecs: Implement IWICMetadataQueryReader::GetLocation.
135135NewVincent PovirkRe: [2/7] windowscodecs: Use PropVariantCompareEx to compare metadata items.
135134Other projectRosanne DiMesio[AppDB] Fix delete button in adminUsers
135133CommittedPierre Schweitzer[PATCH] mpr: Don't stop enumeration on the first failing network provider.
135132Sign-offAndrew EikumRe: [PATCH v3 2/2] msacm32: Implement ACMFORMATCHOOSE_STYLEF_INITTOWFXSTRUCT.
135131Sign-offAndrew EikumRe: [PATCH 1/2] msacm32: Add invalid parameter checks for acmFormatChoose().
135130CommittedZebediah Figura[PATCH v3 2/2] msacm32: Implement ACMFORMATCHOOSE_STYLEF_INITTOWFXSTRUCT.Andrew Eikum✓✓
135129SupersededZebediah Figura[PATCH v2 2/2] msacm32: Implement ACMFORMATCHOOSE_STYLEF_INITTOWFXSTRUCT.Andrew Eikum
135128Sign-offHenri VerbeetRe: [PATCH 1/2] d3drm: Added IDirect3DRMAnimation stub
135127RejectedNikolay Sivov[PATCH 2/2] d3drm: Added IDirect3DRMWrap stubHenri VerbeetOK31806
135126CommittedNikolay Sivov[PATCH 1/2] d3drm: Added IDirect3DRMAnimation stubHenri Verbeet✓✓OK31805
135125CommittedPierre Schweitzer[PATCH] mpr: properly handle the count set to -1 when enumerating connections.
135124CommittedHugh McMaster[PATCH] regedit/tests: Add tests to determine the effects of backslashes in hex dataOK31801
135123CommittedHugh McMaster[PATCH 2/2] reg/tests: Add tests to determine the effects of backslashes in hex dataOK31800
135122CommittedHugh McMaster[PATCH 1/2] reg/tests: Add the final comma to the comma-placement testOK31799
135121CommittedAlistair Leslie-Hughes[PATCH] wmvcore: Support IWMReaderAccelerator in IWMReaderOK31796
135120SupersededZebediah Figura[PATCH 2/2] msacm32: Implement ACMFORMATCHOOSE_STYLEF_INITTOWFXSTRUCT.Andrew Eikum
135119CommittedZebediah Figura[PATCH 1/2] msacm32: Add invalid parameter checks for acmFormatChoose().Andrew Eikum✓✓OK31794
135118AssignedClemens Tamme[PATCH] gdiplus: Write API documentation for GdipAddPathArc and GdipAddPathArcIVincent Povirk
135117CommittedAndrey Gusev[PATCH v4] api-ms-win-core-crt-l2-1-0: Add dll.
135116CommittedAndrey Gusev[PATCH v4] api-ms-win-core-crt-l1-1-0: Add dll.
135115Sign-offAndrew EikumRe: [PATCH 3/4] msacm32: Don't add a format entry if it is decode-only.
135114Sign-offAndrew EikumRe: [PATCH v2 2/4] winemp3.acm: Disallow operations encoding to MPEG.
135113Sign-offAndrew EikumRe: dsound: Fix a memory leak.
135112AssignedPaul Gofman[v5 3/3] d3dx9: Move transpose 'if' outside of the inner loop in set_constants().Matteo Bruni
135110AssignedPaul Gofman[v5 2/3] d3dx9: Get rid of constant's length checking for matrix in set_constants().Matteo Bruni
135111AssignedPaul Gofman[v5 1/3] d3dx9: Remove redundant parameter size check in set_constants().Matteo Bruni
135109CommittedHans Leidekkerwinhttp: Reset content length when a redirect creates a new connection.
135108Sign-offHenri VerbeetRe: [PATCH 3/4] d3drm: Implement appdata property for the rest of objects.
135107Sign-offHenri VerbeetRe: [PATCH 4/4] d3drm: Make it possible to create meshes with CreateObject().
135106Sign-offHenri VerbeetRe: [PATCH 2/4] d3drm: Implement object name property
135105Sign-offHenri VerbeetRe: [PATCH 1/4] d3drm: Make it possible to create material objects with CreateObject().
135104SupersededAndrey Gusev[PATCH v3] api-ms-win-core-crt-l2-1-0: Add dll.
135103SupersededAndrey Gusev[PATCH v3] api-ms-win-core-crt-l1-1-0: Add dll.
135102CommittedHugh McMasterreg/tests: Add tests for parsing hex dataOK31784
135101CommittedHugh McMasterregedit/tests: Add tests for parsing hex dataOK31783
135100Sign-offHuw DaviesRe: [PATCH 3/3] oledb32: Add FIXME for DBTYPE_NUMERIC type
135099Sign-offHuw DaviesRe: [PATCH 2/3] oledb32: Add support for converting to W/STR types in GetConversionSize
135098Sign-offHuw DaviesRe: [PATCH 1/3] oledb32: Supply a default dst len in GetConversionSize
135097Sign-offHuw DaviesRe: [PATCH v2] gdi32: Don't write EMR_EXTSELECTCLIPRGN to emf file on SelectClipPath call
135096CommittedHans Leidekker[2/2] webservices: Add support for dynamic string callbacks.OK31781
135095CommittedHans Leidekker[1/2] webservices: Allow the dictionary functions to be used with any dictionary.
135093CommittedDmitry Timoshkov[2/2] user.exe16: Remove redundant HeapReAlloc.
135094CommittedDmitry Timoshkov[1/2] user.exe16: Fix memory leak in case when HeapReAlloc fails.
135092Needs testsMarcus Meissner[PATCH] oleaut32: check return code of Currency2Integer (Coverity)
135091CommittedDmitry Timoshkovrsaenh: Avoid double 'va_end(args)' in case of a premature loop termination. (v2)
135087AssignedDmitry Timoshkov[7/7] windowscodecs/tests: Add more tests for IWICMetadataQueryReader::GetMetadataByName.Vincent PovirkOK31776
135088AssignedDmitry Timoshkov[6/7] windowscodecs: Add some tests for IWICMetadataQueryReader.Vincent PovirkOK31775
135085AssignedDmitry Timoshkov[5/7] windowscodecs: Add initial implementation of IWICMetadataQueryReader::GetMetadataByName.Vincent Povirk
135090AssignedDmitry Timoshkov[4/7] windowscodecs: Implement IWICBitmapDecoder::GetMetadataQueryReader in the GIF decoder.Vincent Povirk
135089AssignedDmitry Timoshkov[3/7] windowscodecs: Implement IWICMetadataQueryReader::GetLocation.Vincent Povirk
135084AssignedDmitry Timoshkov[2/7] windowscodecs: Use PropVariantCompareEx to compare metadata items.Vincent Povirk
135086CommittedDmitry Timoshkov[1/7] propsys: Add support for VT_LPSTR and VT_LPWSTR to PropVariantCompareEx. (v3)OK31774
135083CommittedDaniel Lehman[PATCH 2/2] opengl32: Don't fail if both PFD_DOUBLEBUFFER_DONTCAREOK31773
135082CommittedDaniel Lehman[PATCH 1/2] opengl32/tests: Add tests for ChoosePixelFormat.OK31772
135081RejectedMax Qian[PATCH 2/2] Update specfiles for last commit
135080RejectedMax Qian[PATCH 1/2] Update make_specfiles to handle ucrtbase's _o_* functions
135079AssignedClemens Tamme[PATCH] gdiplus: Write API doc for GdipAddPathEllipse and GdipAddPathEllipseIVincent Povirk
135076AssignedClemens Tamme[PATCH] gdiplus: Write API for GdipClonePathVincent Povirk
135070SupersededAndrey Gusev[PATCH v2] api-ms-win-core-crt-l2-1-0: Add dll.
135069SupersededAndrey Gusev[PATCH v2] api-ms-win-core-crt-l1-1-0: Add dll.
135068AssignedClemens Tamme[PATCH] gdiplus: Write API for GdipAddPathLine and GdipAddPathLineIVincent Povirk
135065Other projectFrancois Gouget[Tools 3/3] testbot/TestLauncher: Report the exit code as a signed integer.
135064Other projectFrancois Gouget[Tools 2/3] testbot/TestLauncher: Print the process pid on the 'done' lines.
135063Other projectFrancois Gouget[Tools 1/3] testbot/TestLauncher: Fix the 'missing dll' messages.
135062CommittedNikolay Sivov[PATCH 4/4] d3drm: Make it possible to create meshes with CreateObject().Henri Verbeet✓✓OK31763
135061CommittedNikolay Sivov[PATCH 3/4] d3drm: Implement appdata property for the rest of objects.Henri Verbeet✓✓
135060CommittedNikolay Sivov[PATCH 2/4] d3drm: Implement object name propertyHenri Verbeet✓✓OK31762
135059CommittedNikolay Sivov[PATCH 1/4] d3drm: Make it possible to create material objects with CreateObject().Henri Verbeet✓✓OK31761
135052RejectedMartin Storsjo[PATCH v2] configure: Avoid clobbering x18 on arm64 when building with clang
135050CommittedPiotr Caban[PATCH v2] gdi32: Don't write EMR_EXTSELECTCLIPRGN to emf file on SelectClipPath callHuw Davies✓✓OK31757
135049RejectedDmitry Timoshkovuser.exe16: Fix memory leaks in cases when HeapReAlloc fails.
135048SupersededDmitry Timoshkovrsaenh: Avoid double 'va_end(args)' in case of a premature loop termination.
135046CommittedDmitry Timoshkovdsound: Fix a memory leak.Andrew Eikum✓✓
135033AssignedAustin English[PATCH 4/5] d3d9: sync to windows 10Henri Verbeet
135032AssignedAustin English[PATCH 3/5] d3d10_1: label ordinalHenri Verbeet
135030AssignedAustin English[PATCH 2/5] d2d1: sync to windows 10Henri Verbeet
135031RejectedAustin English[PATCH 1/5] cryptnet: label ordinals
135029CommittedAlistair Leslie-Hughes[PATCH 3/3] oledb32: Add FIXME for DBTYPE_NUMERIC typeHuw Davies✓✓
135027CommittedAlistair Leslie-Hughes[PATCH 2/3] oledb32: Add support for converting to W/STR types in GetConversionSizeHuw Davies✓✓OK31746
135028CommittedAlistair Leslie-Hughes[PATCH 1/3] oledb32: Supply a default dst len in GetConversionSizeHuw Davies✓✓OK31745
135026NewOwen Rudge[5/5] wsdapi/tests: Add tests for Get/SetRetransmitParams.OK31743
135025NewOwen Rudge[3/5] wsdapi/tests: Add tests for Get/SetLocalAddress.OK31741
135024NewOwen Rudge[4/5] wsdapi/tests: Add tests for Get/SetRemoteAddress.OK31742
135023NewOwen Rudge[2/5] wsdapi/tests: Add tests for CreateUdpMessageParameters.OK31740
135022NewOwen Rudge[1/5] wsdapi: Add stub implementation of IWSDUdpMessageParameters and WSDCreateUdpMessageParameters.
135010Newkatahiromz .advpack: Improve DelNode and testsOK31732
135003Test failureDmitry Timoshkov[17/17] windowscodecs: Add some tests for IWICMetadataQueryReader.Vincent PovirkFailed31731
135001AssignedDmitry Timoshkov[16/17] windowscodecs: Add initial implementation of IWICMetadataQueryReader::GetMetadataByName.Vincent Povirk
135002AssignedDmitry Timoshkov[15/17] windowscodecs: Implement IWICBitmapDecoder::GetMetadataQueryReader in the GIF decoder.Vincent Povirk
135004AssignedDmitry Timoshkov[14/17] windowscodecs: Implement IWICMetadataQueryReader::GetLocation.Vincent Povirk
135000AssignedDmitry Timoshkov[13/17] windowscodecs: Use PropVariantCompareEx to compare metadata items.Vincent Povirk
134999RejectedDmitry Timoshkov[11/17] windowscodecs: Simplify a bit comparison of two PROPVARIANTs.Vincent Povirk
134996RejectedDmitry Timoshkov[06/17] propsys: Add support for VT_LPSTR and VT_LPWSTR to PropVariantCompareEx. (v2)OK31727
134979SupersededPaul Gofman[v4 4/4] d3dx9: Move transpose 'if' outside of the inner loop in set_constants().Matteo Bruni
134978SupersededPaul Gofman[v4 3/4] d3dx9: Get rid of constant's length checking for matrix in set_constants().Matteo Bruni
134977SupersededPaul Gofman[v4 1/4] d3dx9: Remove redundant parameter size check in set_constants().Matteo Bruni
134976Other projectFrancois Gouget[Tools 2/2] testbot: Force CGI::param() to scalar context for security.
134975Other projectFrancois Gouget[Tools 1/2] testbot: Add Page::GetParamNames() to retrieve a page's parameter names.
134974Test failurekatahiromz .[PATCH] shell32: Initialize members in SHGetFileInfo.
134968RejectedZebediah Figura[PATCH v2 4/5] msi: Don't reimplement record formatting.Hans Leidekker
134957Other projectFrancois Gouget[Tools] testbot/TestLauncher: Trace the time it takes to run each test.
134948Other projectRosanne DiMesio[AppDB] Update rating of old version when a test is moved
134947Other projectRosanne DiMesio[AppDB] Do not show delete button or comment box on manage notes page
134946Other projectRosanne DiMesio[AppDB] Allow users to see their queued screenshots
134938Other projectJulian Rüger[website] Fix unfortunate wording in German translation of release 2.8
134921Other projectJulian Rüger[website] German translation for release 2.10
134920Other projectJulian Rüger[website] German translation for release 2.9
134919Other projectJulian Rüger[website] Update German translation of templates and fix a typo
134918Other projectJulian Rüger[website] German translation for release 2.8
134915NewJack Griggbcrypt: Implement BCryptDeriveKeyPBKDF2 and add test vectors.OK31676
134882SupersededPaul Gofman[v3 3/3] d3dx9: Remove redundant parameter size check in set_constants().Matteo Bruni
134839AssignedZebediah Figura[PATCH] comctl32: Don't FIXME on handled cases.Nikolay Sivov
134831NewJacek Caban[PATCH 12/12] server: Remove no longer needed need_handle from queue_irp.
134830NewJacek Caban[PATCH 11/12] server: Use create_request_async in flush request handler.
134829NewJacek Caban[PATCH 10/12] server: Use create_request_async in ioctl request handler.OK31620
134828NewJacek Caban[PATCH 09/12] ntdll: Set iosb status in server_ioctl_file.
134827NewJacek Caban[PATCH 08/12] server: Allow async_handoff users to set result themselves.
134826RejectedJacek Caban[PATCH 07/12] server: Introduce default async queue that's used if async is not explicitly queued in fd op.
134825NewJacek Caban[PATCH 06/12] server: Use create_request_async for write requests.
134824NewJacek Caban[PATCH 05/12] server: Return async result directly instead of via APCs if it's available.
134823NewJacek Caban[PATCH 04/12] server: Don't call wake_thread in queue_apc for current thread.
134822NewJacek Caban[PATCH 03/12] server: Close async wait handle when wait is satisfied.
134821NewJacek Caban[PATCH 02/12] server: Preallocate wait handle in create_request_async and return it in read request.
134800RejectedAlistair Leslie-Hughes[PATCH] oledb32: Support DBTYPE_I4->DBTYPE_WSTR in GetConversionSizeHuw DaviesOK31607
134783AssignedAlex Henrie[PATCH v3] msxml3: Remove CRs in domtext_put_data and add them in domtext_get_xml.Nikolay SivovOK31591
134775SupersededPaul Gofman[v2 7/7] d3dx9: Move transpose 'if' outside of the inner loop in set_constants().Matteo Bruni
134774SupersededPaul Gofman[v2 6/7] d3dx9: Get rid of constant's length checking for matrix in set_constants().Matteo Bruni
134755CommittedZebediah Figura[PATCH v2 2/4] winemp3.acm: Disallow operations encoding to MPEG.Andrew Eikum✓✓
134746CommittedZebediah Figura[PATCH 3/4] msacm32: Don't add a format entry if it is decode-only.Andrew Eikum✓✓
134723RejectedNikolay Sivov[PATCH 3/3] d3drm/tests: Some tests for mesh builder and facesHenri VerbeetOK31527
134681NewZebediah Figura[PATCH] kernel32: Don't limit physical memory size even if not large address aware.
134680Other projectRosanne DiMesio[AppDB] Return 0 for empty wine-staging checkbox.
134662Other projectFrancois Gouget[Tools] winetest: Improve quoting in the winetest.cron script.
134661Other projectFrancois Gouget[Tools 2/2] winetest: Let the scripts autodetect the work directory.
134660Other projectFrancois Gouget[Tools 1/2] winetest: Get the work directory directly from the web server.
134659Other projectFrancois Gouget[Tools] winetest/build-errors: Fix updating the errors.html file.
134658AssignedZebediah Figura[PATCH] msacm32: Fix bytes written in PCM converter.Andrew Eikum
134645AssignedZebediah Figura[PATCH 12/12] imaadp32.acm: Fix nibble ordering.Andrew Eikum
134644AssignedZebediah Figura[PATCH 11/12] imaadp32.acm: Fix block size calculations.Andrew Eikum
134647AssignedZebediah Figura[PATCH 10/12] msacm32: Remove unnecessary checks from PCM driver.Andrew Eikum
134648AssignedZebediah Figura[PATCH 09/12] msgsm32.acm: Remove unnecessary checks.Andrew Eikum
134643AssignedZebediah Figura[PATCH 08/12] winemp3.acm: Remove unnecessary checks.Andrew EikumFailed31453
134650AssignedZebediah Figura[PATCH 07/12] msg711.acm: Remove unnecessary checks.Andrew Eikum
134646AssignedZebediah Figura[PATCH 06/12] imaadp32.acm: Remove unnecessary checks.Andrew Eikum
134651Test failureZebediah Figura[PATCH 05/12] msadp32.acm: Remove unnecessary checks.Andrew EikumFailed31452
134639NewOwen Rudge[9/9] wsdapi: Implement Get/SetRetransmitParams.OK31447
134638NewOwen Rudge[8/9] wsdapi: Implement Get/SetRemoteAddress.OK31446
134637NewOwen Rudge[7/9] wsdapi: Implement Get/SetLocalAddress.OK31445
134623SupersededPaul Gofman[PATCH 5/5] d3dx9: Move transpose 'if' outside of the inner loop in set_constants().Matteo Bruni
134622SupersededPaul Gofman[PATCH 4/5] d3dx9: Get rid of constant's length checking for matrix in set_constants().Matteo Bruni
134621SupersededPaul Gofman[PATCH 3/5] d3dx9: Remove redundant parameter size check in set_constants().Matteo Bruni
134624AssignedPaul Gofman[PATCH 2/5] d3dx9: Add scalar and vector setting path to set_constants().Matteo Bruni
134620AssignedPaul Gofman[PATCH 1/5] d3dx9: Avoid casting each value separately in set_constants().Matteo Bruni
134578AssignedDaniel Lehman[PATCH v2 2/2] msvcrt: Unwind the catch block frame.Piotr Caban
134577AssignedDaniel Lehman[PATCH v2 1/2] msvcrt: Clean up registered C++ object in handler.Piotr Caban
134565AssignedAric Stewart[PATCH v2] shell32: Implement FCIDM_SHVIEW_CREATELINKNikolay Sivov
134525NewAkihiro Sagawa[PATCH 4/4] kernel32: Update available virtual memory size in GlobalMemoryStatusEx().
134523NewAkihiro Sagawa[PATCH 3/4] ntdll: Use our virtual memory counters when using a process handle.
134524NewAkihiro Sagawa[PATCH 2/4] ntdll: Provide more accurate virtual memory counters.OK31367
134522NewAkihiro Sagawa[PATCH 1/4] ntdll/tests: Add more tests if we have real VM counters.OK31366
134480NewMarcus Meissner[PATCH] fusion: use correct size for ZeroMemory (GCC7)OK31319
134478NewMarcus Meissner[PATCH] use correct size for ZeroMemory (GCC7)OK31317
134405NewAlistair Leslie-Hughes[v3 PATCH 3/3] mplat/test: Added MFCreateMediaType testOK31276
134404NewAlistair Leslie-Hughes[v3 PATCH 2/3] mfplat: Implement MFCreateMediaType
134329AssignedMasanori Kakura[v6 PATCH 3/3] wined3d: Update only dirty regions in wined3d_cs_exec_update_texture().Henri VerbeetOK31234
134328AssignedMasanori Kakura[v6 PATCH 2/3] wined3d: Add dirty region tracking.Henri VerbeetFailed31232
134327AssignedMasanori Kakura[v6 PATCH 1/3] wined3d: Send texture updates through the command stream.Henri Verbeet
134278AssignedMiklós Máté[PATCH 4/4] winegstreamer: fix crashAndrew Eikum
134277AssignedMiklós Máté[PATCH 2/4] quartz: fix crash in FilterGraph2_ConnectAndrew Eikum
134156AssignedDaniel Lehman[PATCH 7/7] msvcrt: Always cleanup registered C++ objects.Piotr Caban
134157AssignedDaniel Lehman[PATCH 6/7] msvcrt: Support rethrowing SEH exceptions.Piotr Caban
134155AssignedDaniel Lehman[PATCH 5/7] msvcrt: Support rethrowing C++ exceptions.Piotr Caban
134154AssignedDaniel Lehman[PATCH 4/7] msvcrt: Simplify unwind logic.Piotr Caban
134153AssignedDaniel Lehman[PATCH 3/7] msvcrt: Unwind the catch block frame.Piotr Caban
134151AssignedDaniel LehmanPATCH 1/7] msvcrt: Translate SEH exception on each call to __CxxFrameHandler.Piotr Caban
133851AssignedJarkko Korpi[PATCH] wined3d: Add Brian Paul recognize codeHenri Verbeet
133850AssignedJarkko Korpi[PATCH V3] wined3d: Add more gl_vendor_string codes for amd cardsHenri Verbeet

Legend

StatusPossible causes
New
  • Patch not even looked at yet, there's still hope...
Pending
  • The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help.
Assigned
  • Waiting for sign-off or feedback from the assigned reviewer. If you don't hear anything after a couple of weeks, please resend the patch.
Committed
  • You have done everything right; congratulations!
  • You screwed up but AJ missed it, send a fix before someone notices ;-)
Dependency
  • The patch is part of a series in which a previous patch hasn't been applied. Resend when the dependent patch is fixed.
Bad sequence
  • The patch is part of a series but it's not correctly numbered. Resend the series with correct sequence numbers to enable the testbot to figure it out.
Superseded
  • An updated version of the patch has been submitted.
  • Someone else fixed the problem already.
Needs tests
  • You need to write some test cases demonstrating that the patch is correct.
Deferred
  • The patch is deferred because of code freeze for an upcoming release. Either resend after the release, make the patch less intrusive, or make a convincing argument that it needs to be included in the release.
Sign-off
  • This is a Signed-off-by reply to another patch.
Reply
  • The mail is a reply to another patch.
Other project
  • The patch belongs to another WineHQ project (website, appdb, etc.) and will be applied by the respective maintainer.
Apply failure
  • The patch got mangled in transit.
  • It's not relative to the latest git.
  • Someone else sent a patch that changes the same area and causes conflicts.
  • The patch is relative to a subdirectory (using 'git format-patch' is strongly recommended).
Build failure
  • Syntax error or other compile problem.
  • You forgot to include some changes or new files required for compilation.
  • The patch causes compiler warnings (maintainer mode implies -Werror).
Authorship
  • The patch author's full name, email address, or Signed-off-by headers are incorrect or missing.
Formatting
  • Whitespace got mangled in transit.
  • Indentation is messed up (usually from editing with a non-standard tab size).
  • 8-bit chars got mangled in transit (usually when sending patches to translation files).
  • You are making gratuitous formatting changes to the code.
  • You are using C++ comments.
No patch
  • You hit 'send' before attaching the patch.
Rejected
  • The patch has been rejected with a comment on wine-devel or #winehackers.
  • The patch contains an obvious error that you are expected to figure out yourself.
Needs splitting
  • A single mail contained multiple patch files.
  • The patch contains unrelated changes that should be sent as separate patches.
  • The patch is simply too large for review, you need to find a way to split it.
Test failure
  • You didn't run 'make test' before submitting.
  • The patch requires a Wine fix but doesn't use todo_wine.
  • The patch fixes a failure but doesn't remove the corresponding todo_wine.
  • The testbot detected new failures on Windows.