Wine source repository – Patch status
IDStatusAuthorSubjectTestbotJob ID
106150NewZhenbo Li mshtml: Added IHTMLStyle::listStyle property implementation.OK8601
106149NewHenri Verbeet [PATCH 5/5] wined3d: Keep a reference to the backbuffer textures instead of the surfaces in the swapchain.
106148NewHenri Verbeet [PATCH 4/5] wined3d: Keep a reference to the frontbuffer texture instead of the surface in the swapchain.
106147NewHenri Verbeet [PATCH 3/5] wined3d: Use the texture draw binding instead of the surface draw binding.
106146NewHenri Verbeet [PATCH 2/5] wined3d: Move the "swapchain" field from struct wined3d_surface to struct wined3d_texture.
106145NewHenri Verbeet [PATCH 1/5] wined3d: Replace surface_update_draw_binding() with wined3d_resource_update_draw_binding().
106144NewJacek Caban mshtml: Override default onsubmit action with our submit implementation.
106143NewYongHao Hu msvcp90: Added complex_float_pow implementation(Fix precision) and tests(Try 4)OK8600
106142NewYongHao Hu msvcp90: Added complex_float_pow implementation(Fix precision) and tests(Try 4)OK8599
106141NewGerald Pfeifer ws2_32: Define fill_control_message only when it's really used. (RESEND)
106140NewAndrei Slăvoiu [3/5] wined3d: replace vendor specific callbacks with generic code that uses vendor specific arrays (try 2)
106139NewDonnieWalburn Re: programs/dxdiag: Create dummy application
106138NewYongHao Hu msvcp90: Added complex_float_pow implementation(Fix precision) and tests(Try 4)OK8598
106137NewShuai Meng [PATCH 2/2] vbscript: Implemented Time(try 2)Failed8592
106136NewShuai Meng [PATCH 1/2] vbscript: Implemented Date(try 2)Failed8591
106135CommittedJacek Caban d3d10_1.idl: Added _D3D10_1_CONSTANTS guard.
106134CommittedStefan Dösinger [PATCH 2/2] ddraw: Do not set lpSurface in GetSurfaceDesc.OK8590
106133CommittedStefan Dösinger [PATCH 1/2] ddraw: Clear application-passed lpSurface pointers.OK8589
106132CommittedPiotr Caban oleaut32: Add support for VAR_TIMEVALUEONLY and VAR_DATEVALUEONLY flags in VarDateFromUdateExOK8584
106131CommittedHenri Verbeet [PATCH 5/5] wined3d: Replace surface_is_offscreen() with wined3d_resource_is_offscreen().
106130CommittedHenri Verbeet [PATCH 4/5] wined3d: Move the "map_binding" field from struct wined3d_surface to struct wined3d_resource.
106128CommittedHenri Verbeet [PATCH 3/5] wined3d: Explicitly destroy the surface in texture2d_sub_resource_cleanup().
106129CommittedHenri Verbeet [PATCH 2/5] wined3d: Explicitly destroy the volume in texture3d_sub_resource_cleanup().
106127CommittedHenri Verbeet [PATCH 1/5] wined3d: Recognize some more AMD cards.
106126CommittedNikolay Sivov wrc: Remove some always-true conditions (PVS-Studio)
106125CommittedNikolay Sivov dwrite: Use layout pointer as an argument instead of neutral list
106124CommittedFrancois Gouget shell32: Add a trailing '\n' to a FIXME().
106123CommittedFrancois Gouget shell32/tests: Add a trailing '\n' to a couple of win_skip() calls.OK8582
106122CommittedFrancois Gouget rsaenh/tests: Add a trailing '\n' to some ok() calls.OK8581
106121NewAndré Hentschel [14/14] wpcap: Implement wsockinit
106120NewAndré Hentschel [13/14] wpcap: Implement pcap_setnonblock
106119NewAndré Hentschel [12/14] wpcap: Implement pcap_sendpacket
106118NewAndré Hentschel [11/14] wpcap: Implement pcap_next_ex
106117NewAndré Hentschel [10/14] wpcap: Implement pcap_next
106116NewAndré Hentschel [9/14] wpcap: Implement pcap_getnonblock
106115NewAndré Hentschel [8/14] wpcap: Implement pcap_open
106114CommittedAndré Hentschel [7/14] wpcap: Implement pcap_get_airpcap_handle
106113CommittedAndré Hentschel [6/14] wpcap: Implement pcap_set_datalink
106112CommittedAndré Hentschel [5/14] wpcap: Implement pcap_datalink_val_to_description
106111CommittedAndré Hentschel [4/14] wpcap: Implement pcap_list_datalinks
106110CommittedAndré Hentschel [3/14] wpcap: Implement pcap_datalink_name_to_val
106109CommittedAndré Hentschel [2/14] wpcap: Implement pcap_close
106108CommittedAndré Hentschel [1/14] wpcap: Implement pcap_datalink_val_to_name
106107No patchVincent Povirk Re: [1/2] wbemprox: Implement __SystemSecurity::GetSD.
106106NewVincent Povirk [2/2] wbemprox: Stub __SystemSecurity::SetSD.
106105Test failureVincent Povirk [1/2] wbemprox: Implement __SystemSecurity::GetSD.Failed8576
106104CommittedVincent Povirk [2/2] mscoree: Factor out common code for calling .NET methods.
106103CommittedVincent Povirk [1/2] mscoree: Implement corruntimehost_CreateDomainSetup.
106102CommittedJacek Caban mshtml: Fixed handling NULL argument in IHTMLElement::contains implementation.OK8573
106101CommittedZhenbo Li [PATCH 2/2] mshtml: Added IHTMLStyle::backgroundAttachment property (resend) implementation.OK8572
106100CommittedZhenbo Li [PATCH 1/2] mshtml: Added IHTMLStyle2::tableLayout property (resend) implementation.OK8571
106099CommittedShuai Meng [PATCH 7/7] vbscript: Implemented Log(try 4)Failed8570
106098CommittedShuai Meng [PATCH 6/7] vbscript: Implemented Exp(try 4)Failed8569
106097CommittedShuai Meng [PATCH 5/7] vbscript: Implemented Atn(try 4)Failed8568
106096CommittedShuai Meng [PATCH 4/7] vbscript: Implemented Tan(try 4)Failed8567
106095CommittedShuai Meng [PATCH 3/7] vbscript: Implemented Sin(try 4)Failed8566
106094CommittedShuai Meng [PATCH 2/7] vbscript: Implemented Cos(try 4)Failed8565
106093CommittedShuai Meng [PATCH 1/7] vbscript: Implemented Sqr(try 4)Failed8564
106092NewBernhard Reiter imagehlp: Implement (parts of) BindImageEx (try 12)OK8563
106091CommittedZhenbo Li [PATCH 9/9] mshtml: Added IHTMLInputElement_get_form method (resend) implementation.OK8562
106089CommittedZhenbo Li [PATCH 8/9] mshtml: Added IHTMLInputElement::readOnly property. (resend)OK8561
106090CommittedZhenbo Li [PATCH 7/9] mshtml: Added IHTMLImgElement::align property (resend) implementation.OK8560
106088CommittedZhenbo Li [PATCH 6/9] mshtml: Added IHTMLInputElement::size property (resend) implementation.OK8559
106087CommittedZhenbo Li [PATCH 5/9] mshtml: Added IHTMLImgElement::isMap property (resend) implementation.OK8558
106086CommittedZhenbo Li [PATCH 4/9] mshtml: Added IHTMLTableCell::align property (resend) implementation.OK8557
106085CommittedZhenbo Li [PATCH 3/9] mshtml: Added IHTMLTable::frame property implementation (resend)OK8556
106084CommittedZhenbo Li [PATCH 2/9] mshtml: Added IHTMLTable::insertRow/deleteRow methods (resend) implementation.OK8555
106083CommittedZhenbo Li [PATCH 1/9] mshtml/tests: Fix test_tr_modify(). (resend)OK8554
106082CommittedHenri Verbeet [PATCH 5/5] wined3d: Store the amount of video memory as a UINT64.
106081CommittedHenri Verbeet [PATCH 4/5] d3d9: wined3d_device_get_available_texture_mem() returns a UINT.
106080CommittedHenri Verbeet [PATCH 3/5] d3d8: wined3d_device_get_available_texture_mem() returns a UINT.
106078CommittedHenri Verbeet [PATCH 2/5] ddraw: Clamp video memory to UINT_MAX in ddraw7_GetAvailableVidMem().
106079CommittedHenri Verbeet [PATCH 1/5] d3d9: The "forwardReference" field in struct d3d9_surface is always a texture, if set.
106077CommittedNikolay Sivov [2/2] dwrite: Implement layout getters derived from text formatOK8552
106076CommittedNikolay Sivov [1/2] dwrite: Implement ranges mergingOK8551
106075SupersededShuai Meng [PATCH 7/7] vbscript: Implemented Log(try 3)Failed8550
106074SupersededShuai Meng [PATCH 6/7] vbscript: Implemented Exp(try 3)Failed8549
106073SupersededShuai Meng [PATCH 5/7] vbscript: Implemented Atn(try 3)Failed8548
106072SupersededShuai Meng [PATCH 4/7] vbscript: Implemented Tan(try 3)Failed8547
106071SupersededShuai Meng [PATCH 3/7] vbscript: Implemented Sin(try 3 )Failed8546
106070SupersededShuai Meng [PATCH 2/7] vbscript: Implemented Cos(try 3)Failed8545
106069SupersededShuai Meng [PATCH 1/7] vbscript: Implemented Sqr(try 3)Failed8544
106068NewVijay Kiran Kamuju Add new dll kernelbase.dll
106067NewAric Stewart (resend 2)[5/5]dwrite: Implement TryGetFontTable and ReleaseFontTable
106066NewAric Stewart (resend 2)[4/5]dwrite: Initial implementation of CreateFontFace
106065CommittedBernhard Reiter imagehlp/tests: Add test for BindImageEx with NULL as StatusRoutine.OK8534
106064CommittedNikolay Sivov winhttp: Fix return code check (PVS-Studio)
106063CommittedNikolay Sivov [3/3] oleaut32/tests: Remove duplicate code blocks (PVS-Studio)OK8533
106062CommittedNikolay Sivov [2/3] oleaut32/tests: Remove redundant assignment (PVS-Studio)OK8532
106061CommittedNikolay Sivov [1/3] oleaut32/tests: Remove redundant assignment (PVS-Studio)OK8531
106060CommittedNikolay Sivov oleaut32: Remove duplicated expression (PVS-Studio)
106059CommittedNikolay Sivov urlmon: Remove duplicated check (PVS-Studio)
106058CommittedNikolay Sivov mshtml: Free buffer for empty strings too (PVS-Studio)
106057CommittedNikolay Sivov odbccp32/tests: Remove test of always true conditions (PVS-Studio)OK8530
106056Test failureNikolay Sivov ddraw/tests: Correct test condition (PVS-Studio)Failed8529
106055CommittedNikolay Sivov secur32/tests: Remove duplicated expression (PVS-Studio)OK8528
106054CommittedNikolay Sivov comctl32/pager: Reduce pointer scope so it doesn't point to inner scope vars (PVS-Studio)
106053CommittedAndré Hentschel [6/15] wpcap: Implement pcap_loop (try 2)
106052CommittedAndré Hentschel [5/15] wpcap: Implement pcap_dispatch (try 2)
106051SupersededAndré Hentschel [15/15] wpcap: Implement pcap_open
106050SupersededAndré Hentschel [14/15] wpcap: Implement pcap_get_airpcap_handle
106049SupersededAndré Hentschel [13/15] wpcap: Implement pcap_set_datalink
106048SupersededAndré Hentschel [12/15] wpcap: Implement pcap_datalink_val_to_description
106047SupersededAndré Hentschel [11/15] wpcap: Implement pcap_list_datalinks
106046SupersededAndré Hentschel [10/15] wpcap: Implement pcap_datalink_name_to_val
106045SupersededAndré Hentschel [9/15] wpcap: Implement pcap_close
106044SupersededAndré Hentschel [8/15] wpcap: Implement pcap_datalink_val_to_name
106043CommittedAndré Hentschel [7/15] wpcap: Implement pcap_breakloop
106042SupersededAndré Hentschel [6/15] wpcap: Implement pcap_loop
106041SupersededAndré Hentschel [5/15] wpcap: Implement pcap_dispatch
106040CommittedAndré Hentschel [4/15] wpcap: Implement pcap_snapshot
106039CommittedAndré Hentschel [3/15] wpcap: Implement pcap_freecode
106038CommittedAndré Hentschel [2/15] wpcap: Trace strings when possible
106037No patchAndré Hentschel [0/15] Summary
106036CommittedAndré Hentschel [1/15] wpcap: Fix spec file to not print empty buffers
106035CommittedAndré Hentschel shlwapi/tests: Fix SHFormatDateTimeW tests for right-to-left localesOK8506
106034CommittedJacek Caban d3d11.idl: Added some missing declarations.
106033CommittedJacek Caban d3d10_1.idl: Added some missing constants.
106032CommittedLauri Kenttä [PATCH] po: Update Finnish translation.
106031SupersededZhenbo Li mshtml: Added IHTMLTableCell::align property implementation.(try 2)OK8503
106029SupersededZhenbo Li mshtml: Added IHTMLStyle2::tableLayout property implementation.OK8501
106028SupersededZhenbo Li mshtml/tests: Fix test_tr_modify().OK8500
106027SupersededZhenbo Li mshtml: Added IHTMLTable::insertRow/deleteRow methods implementation.(try 2)OK8499
106026SupersededZhenbo Li mshtml: Added IHTMLInputElement_get_form method implementation. (try 4)OK8496
106025SupersededZhenbo Li mshtml: Added IHTMLInputElement::readOnly property. (try 2)OK8495
106024SupersededZhenbo Li mshtml: Added IHTMLImgElement::isMap property implementation.(try 3)OK8493
106023SupersededShuai Meng [PATCH 7/7] vbscript: Implemented Atn(try 2)Failed8490
106022SupersededShuai Meng [PATCH 6/7] vbscript: Implemented Sqr(try 2)Failed8489
106021SupersededShuai Meng [PATCH 5/7] vbscript: Implemented Log(try 2)Failed8488
106020SupersededShuai Meng [PATCH 4/7] vbscript: Implemented Exp(try 2)Failed8487
106019SupersededShuai Meng [PATCH 3/7] vbscript: Implemented Tan(try 2)Failed8486
106018SupersededShuai Meng [PATCH 2/7] vbscript: Implemented Sin(try 2)Failed8485
106017SupersededShuai Meng [PATCH 1/7] vbscript: Implemented Cos(try 2)Failed8484
106010PendingAustin English advapi32: add stubs for *EncryptedFileRaw* functions
106008NewAric Stewart dwrite: Make gdiinterop an allocated object
106007NewAndrei Slăvoiu [5/5] wined3d: pass the capabilities directly to d3d_level_from_gl_info and rename it to d3d_level_from_caps (resend)
106006NewAndrei Slăvoiu [3/5] wined3d: replace vendor specific callbacks with generic code that uses vendor specific arrays (resend)
106005NewAndrei Slăvoiu [4/5] wined3d: adjust the Intel fallbacks to better reflect reality (resend)
106004Other projectJulian Rüger [website] German translation for release 1.7.24
106002NewSebastian Lackner [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.Failed8473
106001NewSebastian Lackner [3/4] server: Implement set_named_pipe_info wineserver call for NtSetInformationFile/FilePipeInformation.
106000NewSebastian Lackner [2/4] server: Store pipe_flags in a separate variable for both server and client of named pipes.
105999NewSebastian Lackner [1/4] ntdll: Implement FILE_PIPE_INFORMATION for NtQueryInformationFile.
105998NewAric Stewart (resend)[5/5]dwrite: Implement TryGetFontTable
105997NewAric Stewart (resend)[4/5]dwrite: Initial immplementation of CreateFontFaceOK8471
105996NewAric Stewart (resend)[3/5]dwrite: Begining implementation of IDWriteFontFile_AnalyzeOK8470
105995NewAric Stewart (resend)[2/5]dwrite: Initial implementation of CreateCustomFontFileReferenceOK8469
105994NewAric Stewart (resend)[1/5]dwrite: Implement Font File Loader registrationOK8467
105988SupersededZhenbo Li mshtml: Added IHTMLStyle::backgroundAttachment property implementation.OK8459
105987NewHugh McMaster regsvr32: Add missing 'const' keyword
105986SupersededZhenbo Li mshtml: Added IHTMLTable::frame property implementationOK8454
105975NewGuillaume Charifi [3/3] oleaut32: Remove todo_wineOK8447
105974NewGuillaume Charifi [2/3] oleaut32: Implement TLB dependencies lookup in resources
105973NewGuillaume Charifi [1/3] oleaut32: Add test for TLB dependencies lookup in resources (try 3)OK8445
105971SupersededZhenbo Li mshtml: Added IHTMLInputElement::size property implementation.OK8442
105969NewCzBiX shell32: Implemented KF_FLAG_DEFAULT_PATH for SHGetKnownFolderPath.OK8439
105966NewJactry Zeng [PATCH 6/8] riched20: Implement IText{Selection, Range}::Set{Start, End}.OK8434
105965NewJactry Zeng [PATCH 8/8] riched20: Stub for ITextPara interface and implement ITextRange::GetPara.OK8436
105964NewJactry Zeng [PATCH 7/8] riched20: Stub for ITextFont interface and implement ITextRange::GetFont and ITextSelection::GetFont.OK8435
105963NewJactry Zeng [PATCH 5/8] riched20: Implement ITextRange::Collapse and ITextSelection::Collapse.OK8433
105962NewJactry Zeng [PATCH 4/8] riched20: Implement ITextRange::GetDuplicate.OK8432
105961NewJactry Zeng [PATCH 3/8] riched20: Implement IText{Selection, Range}::Get{Start, End}.OK8431
105960NewJactry Zeng [PATCH 2/8] riched20: Implement ITextSelection::GetChar and ITextRange::GetChar. (try 2 rebase)OK8430
105959NewJactry Zeng [PATCH 1/8] riched20: Stub for ITextRange interface and implement ITextDocument::Range. (try 4)OK8429
105957NewBrad Baago Updated return values for DecryptFileW and DecryptFileA according to windows standards.
105949SupersededShuai Meng [PATCH 2/2] vbscript: Implemented TimeFailed8405
105948SupersededShuai Meng [PATCH 1/2] vbscript: Implemented DateFailed8404
105947RejectedYongHao Hu msvcp90: Add complex_float << implementation
105946NewYongHao Hu msvcp90: Fix comment typo
105945RejectedYongHao Hu msvcp90: Added complex_float_pow impletation(Fix precision) and tests(Try 3)OK8403
105943PendingBruno Jesus dmscript/tests: Initialize test variable (valgrind)OK8396
105940NewGerald Pfeifer ws2_32: Define fill_control_message only when it's really used.
105936NewDavid Woodhouse secur32: Fix handling of ANSI NTLM credentials
105925NewDamjan Jovanovic winex11.drv: import X11's "text/html" as "HTML Format" (try 3)
105903NewHugh McMaster [Patch 2/2] regsvr32: Convert source to Unicode
105902NewHugh McMaster [Patch 1/2] regsvr32: Simplify command line handling
105886NewSebastian Lackner ntdll: Set ldr.EntryPoint for main executable.
105879NewShuai Meng [PATCH 2/2] vbscript: Implemented IntFailed8295
105878NewShuai Meng [PATCH 1/2] vbscript: Implemented FixFailed8294
105857NewAndrei Slăvoiu [5/5] wined3d: pass the capabilities directly to d3d_level_from_gl_info and rename it to d3d_level_from_caps
105859NewAndrei Slăvoiu [4/5] wined3d: adjust the Intel fallbacks to better reflect reality
105856NewAndrei Slăvoiu [3/5] wined3d: replace vendor specific callbacks with generic code that uses vendor specific arrays
105854NewJoris van der Wel [4/4] server: implement passing a thread security descriptor to CreateProcessOK8253
105853NewJoris van der Wel [3/4] server: implement passing a process security descriptor to CreateProcessOK8252
105851NewJoris van der Wel [2/4] server: Support sending process and thread security descriptors for the "new_process" request in the protocol
105852NewJoris van der Wel [1/4] server: A new function "set_sd_defaults_from_token" that sets the security descriptor along with a token that will be used to gather defaults, instead of always using the primary token. (try 4)
105846PendingDavid Hedberg gdiplus: Add stub for GdipCreateEffect.
105845SupersededZhenbo Li mshtml: Added IHTMLImgElement::align property implementation.OK8231
105837NewAric Stewart (Resend 2)[4/5] imm32: Restrict crossthread Association and destructionOK8221
105835SupersededZhenbo Li mshtml: Added IHTMLImgElement::isMap property implementation.OK8218
105812NewErich E. Hoover[PATCH 2/2] ddraw: Return empty D3D hardware flags for HEL device enumeration.OK8199
105811NewErich E. Hoover[PATCH 1/2] ddraw/tests: Ignore broken behavior of D3DTRANSFORM_UNCLIPPED.OK8198
105810NewErich E. Hoover[PATCH 2/2] server: Add default security descriptor DACL for processes (resend).OK8197
105809NewErich E. Hoover[PATCH 1/2] server: Add default security descriptor ownership for processes (resend).OK8196
105808NewDavid Hedberg shell32: Implement IEnumShellItems for IShellItemArray.Failed8193
105799NewAric Stewart (Retry)[6/6]imm32: limit cross thread access to ImmSet* functions
105798NewAric Stewart (Retry)[4/5] imm32: Restrict crossthread Association and destructionFailed8186
105797NewAric Stewart (Retry)[3/5] imm32: use thread data from target HWNDOK8185
105795NewAric Stewart (Retry)[2/5] imm32: do not let ImmDestroyContext destroy any default contexts
105796NewAric Stewart (Retry)[1/5] imm32: Move thread data from TLSEntry to an internal list
105792NewFrancois Gouget [Tools 2/2] winetest: Add a license to the winetest.cron script.
105793NewFrancois Gouget [Tools 1/2] winetest: Automatically detect the root of the website.
105788NewPiotr Caban [PATCH 2/2] user32: Load imm32.dll when user32 is loadedOK8171
105787NewPiotr Caban [PATCH 1/2] imm32: Register IME window class on first use
105786PendingSebastian Lackner [2/2] wine.inf: Add Dynamic DST exceptions for Israel Standard Time.
105785PendingSebastian Lackner [1/2] ntdll: Add support for Dynamic DST (daylight saving time) information in registry.
105780SupersededZhenbo Li mshtml: Added IHTMLInputElement_get_form method implementation. (try 3)OK8145
105779SupersededZhenbo Li [3/3] mshtml/tests: Add tests for modifying IHTMLTable.OK8140
105778SupersededZhenbo Li [2/3] mshtml: Added IHTMLTable::deleteRow method implementation.
105777SupersededZhenbo Li [1/3] mshtml: Added IHTMLTable::insertRow method implementation.
105776SupersededZhenbo Li mshtml: Added IHTMLOptionElement::defaultSelected property implementation.OK8137
105771SupersededZhenbo Li mshtml: Added IHTMLInputElement_get_form method implementation. (try 2)OK8135
105740PendingMarcus Meissner [PATCH] mscoree: Fixed use after free (Coverity)
105739PendingAustin English npptools: add stub dll
105672PendingMarcus Meissner [PATCH] winetest: add integer bytes_recv variable (Coverity)


StatusPossible causes
  • Patch not even looked at yet, there's still hope...
  • The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help.
  • Waiting for feedback from the main developer in that area.
  • You have done everything right; congratulations!
  • You screwed up but AJ missed it, send a fix before someone notices ;-)
  • The patch is part of a series in which a previous patch hasn't been applied. Resend when the dependent patch is fixed.
Bad sequence
  • The patch is part of a series but it's not correctly numbered. Resend the series with correct sequence numbers to enable the testbot to figure it out.
  • An updated version of the patch has been submitted.
  • Someone else fixed the problem already.
Needs tests
  • You need to write some test cases demonstrating that the patch is correct.
  • The patch is deferred because of code freeze for an upcoming release. Either resend after the release, make the patch less intrusive, or make a convincing argument that it needs to be included in the release.
Other project
  • The patch belongs to another WineHQ project (website, appdb, etc.) and will be applied by the respective maintainer.
Apply failure
  • The patch got mangled in transit.
  • It's not relative to the latest git.
  • Someone else sent a patch that changes the same area and causes conflicts.
  • The patch is relative to a subdirectory (using 'git format-patch' is strongly recommended).
Build failure
  • Syntax error or other compile problem.
  • You forgot to include some changes or new files required for compilation.
  • The patch causes compiler warnings (maintainer mode implies -Werror).
  • The patch author's full name or email address are incorrect or missing.
  • Whitespace got mangled in transit.
  • Indentation is messed up (usually from editing with a non-standard tab size).
  • 8-bit chars got mangled in transit (usually when sending patches to resource files).
  • You are making gratuitous formatting changes to the code.
  • You are using C++ comments.
No patch
  • You hit 'send' before attaching the patch.
  • The mail is a reply to another patch, or spam.
  • The patch has been rejected with a comment on wine-devel or #winehackers.
  • The patch contains an obvious error that you are expected to figure out yourself.
Needs splitting
  • A single mail contained multiple patch files.
  • The patch contains unrelated changes that should be sent as separate patches.
  • The patch is simply too large for review, you need to find a way to split it.
Test failure
  • You didn't run 'make test' before submitting.
  • The patch requires a Wine fix but doesn't use todo_wine.
  • The patch fixes a failure but doesn't remove the corresponding todo_wine.
  • The testbot detected new failures on Windows.