Wine source repository – Patch status
IDStatusAuthorSubjectTestbotJob ID
107366NewHuw Davies comctl32/tests: Post a key-down message rather than use keybd_event.OK9935
107365NewMichael Stefaniuc urlmon/tests: Visually separate two if statements (PVS-Studio)OK9932
107364NewAustin English ntoskrnl.exe: add a stub for IoRegisterPlugPlayNotification
107363NewQian Hong [PATCH 2/2] user32/tests: Test exception handling for timer callbacks.Failed9924
107362NewQian Hong [PATCH 1/2] user32: Add more exception handlings for timer callbacks.
107361NewNikolay Sivov [PATCH 3/3] dwrite/tests: Some tests for custom font collectionsOK9922
107360NewNikolay Sivov [PATCH 2/3] dwrite: Remove null checks for family and collection pointers, those are always set now
107359PendingNikolay Sivov [PATCH 1/3] dwrite: Map Mac language id to locale name
107358CommittedBruno Jesus comctl32/tests: Remove a dead assignment from dpa.c (Cppcheck)OK9915
107357CommittedBruno Jesus comctl32/tests: Remove dead assignment in comboex.c (Cppcheck)OK9914
107356CommittedBruno Jesus comctl32: Remove dead assignment in tooltips.c (Cppcheck)
107355CommittedBruno Jesus comctl32: Avoid magic numbers
107354CommittedBruno Jesus comctl32: Remove a dead assignment in comctl32undoc.c (Cppcheck)
107353CommittedBruno Jesus atl: Remove dead assignment
107352CommittedBruno Jesus atl: Remove dead assignment
107351CommittedBruno Jesus advpack/tests: Remove dead assignment (Cppcheck)OK9913
107350CommittedBruno Jesus advapi32/tests: Remove dead assignment (Cppcheck)OK9912
107349CommittedBruno Jesus advapi32/tests: Fix copy & paste issue (Cppcheck)OK9911
107348CommittedMichael Stefaniuc wininet: Simplify while loop conditions (PVS-Studio)
107347PendingMichael Stefaniuc winex11.drv: Fix logical error in if-condition (PVS-Studio)
107346CommittedMichael Stefaniuc riched20: SUCCEEDED() is already a BOOL (PVS-Studio)
107345CommittedMichael Stefaniuc comdlg32: Use the proper macro to create an int atom (PVS-Studio)
107344NewPatrick Rudolph [2/2] ddraw: return DDERR_INVALIDPARAMS on too large surface dimensionsOK9909
107343NewPatrick Rudolph [1/2] ddraw: add dsurface dimension tests, try 12OK9908
107342CommittedHans Leidekker msi: Format registry values before interpreting value type.Failed9898
107341CommittedHans Leidekker msvcrt: Implement _snprintf_l.
107340CommittedMichael Stefaniuc d3drm: Pass the correct pointer to IDirectXFileData_GetData (PVS-Studio)
107339CommittedAlistair Leslie-Hughes dplayx: Fix some crashes and wine_todo's ( try 3)Failed9894
107338CommittedNikolay Sivov msxml3: Return S_FALSE in getNamedItem() of PI nodeOK9889[PATCH] Mystery hang reduction -- clear new allocations
107336CommittedBruno Jesus programs/regedit: Allow importing/exporting strings with '\r'
107335CommittedMichael Stefaniuc wined3d: Remove no-op min() with magic number (PVS_Studio)
107334NewJoachim Priesner [2/2] wined3d: wined3d: Take abs() of vertex z coordinate as FFP fog coordinate (try 2)OK9869
107333NewJoachim Priesner [1/2] wined3d: Set D3DPMISCCAPS_FOGVERTEXCLAMPED flag in get_device_caps (resend)
107332CommittedNikolay Sivov [PATCH 4/4] dwrite: Store pixels per dip value for a render targetOK9866
107331CommittedNikolay Sivov [PATCH 3/4] dwrite: Turn fixme to trace in Analyze()
107330CommittedNikolay Sivov [PATCH 2/4] dwrite: Implement system font collection as any other font collectionOK9865
107329CommittedNikolay Sivov [PATCH 1/4] dwrite: Properly null-terminate name string when converting to WCHAR
107328CommittedVincent Povirk gdiplus: Fix error when drawing from a rectangle outside bitmap bounds.
107327CommittedAustin English [2/2] ntoskrnl.exe: add ObQueryNameString stub (resend)
107326CommittedAustin English [1/2] ndis.sys add a stub dll (try 2)
107325NewMatteo Bruni [PATCH 5/5] d3d8/tests: Add a test for ATI1N and ATI2N texture formats.OK9864
107324NewMatteo Bruni [PATCH 4/5] d3d9/tests: Add a test for ATI1N and ATI2N texture formats.OK9863
107323NewMatteo Bruni [PATCH 3/5] wined3d: Dirtify pixel shader on texture format change.
107322NewMatteo Bruni [PATCH 2/5] wined3d: Add ATI1N texture format support.
107321CommittedMatteo Bruni [PATCH 1/5] wined3d: Check ARB_TEXTURE_COMPRESSION_RGTC for applying the correct fixup.
107320No patchJacek Caban Re: [PATCH] mshtml: check null before release the elem object
107319CommittedJacek Caban mshtml: Don't call stop_binding in error cases in start_binding.
107316SupersededAlistair Leslie-Hughes dplayx: Fix some crashes and wine_todo's ( try 2)OK9846
107306SupersededVincent Povirk gdiplus: Fix error when drawing from a rectangle outside bitmap bounds.
107302SupersededAustin English (2/2) ntoskrnl.exe: add ObQueryNameString stub
107301SupersededAustin English [1/2] ndis.sys: add a stub dll
107300RejectedGuillaume Charifi [2/2] oleaut32: Implement TLB dependencies lookup in resources (resend 3 - last submit before abandon)
107297NewStefan Dösinger [PATCH] d3d8/tests: The device restores the mode settings from the registry (v3).Failed9818
107296CommittedHuw Davies comctl32: Enable the appropriate wizard buttons before sending DM_SETDEFID.Failed9817
107294NewIván Matellanes[6/6] msvcrt: Use correct type for return values in fread and fwrite
107293NewIván Matellanes[5/6] msvcrt: Avoid locking the file in _fclose_nolock
107292RejectedIván Matellanes[4/6] msvcrt: Added _fread_nolock_s implementation
107291CommittedIván Matellanes[3/6] msvcrt: Added _fgetwc_nolock implementation
107290CommittedIván Matellanes[2/6] msvcrt: Added _fgetc_nolock implementation
107289CommittedIván Matellanes[1/6] msvcrt: _filbuf should not lock any file (resend)OK9815
107288CommittedJactry Zeng [PATCH 3/3] riched20: Add IID_IRichEditOle and IID_ITextDocument support for ITextServices::QueryInterface. (try 2)OK9814
107287CommittedJactry Zeng [PATCH 2/3] riched20: Add COM aggregation support for IRichEditOle. (try 4)
107286CommittedJactry Zeng [PATCH 1/3] riched20: Fix a leak.
107283PendingJoachim Priesner ws2_32: WS_get_local_ips: Fix ordering of IP addresses by metric if two addresses have the same metric (try 2)
107282SupersededNikolay Sivov [PATCH 8/8] dwrite: Turn fixme to trace in Analyze()
107281SupersededNikolay Sivov [PATCH 7/8] dwrite: Implement system font collection as any other font collectionOK9804
107273SupersededJoachim Priesner [2/2] wined3d: wined3d: Take abs() of vertex z coordinate as FFP fog coordinateOK9796
107272SupersededJoachim Priesner [1/2] wined3d: Set D3DPMISCCAPS_FOGVERTEXCLAMPED flag in get_device_caps
107271PendingAndré Hentschel propsys: Don't shift negative value
107264NewStefan Dösinger [PATCH 3/3] ddraw/tests: Port test_mode_change to ddraw (v2)OK9792
107263NewStefan Dösinger [PATCH 2/3] d3d8/tests: The device restores the mode settings from the registry (v2).Failed9791
107262NewStefan Dösinger [PATCH 1/3] d3d9/tests: The device restores the mode settings from the registry (v2).OK9790
107258NewJonathan Vollebregt [PATCH 6/6] reg: Clean up reg_deleteOK9779
107257NewJonathan Vollebregt [PATCH 5/6] reg: Clean up reg_addOK9778
107256NewJonathan Vollebregt [PATCH 4/6] reg: Add wchar/raw data conversion functionsOK9777
107255NewJonathan Vollebregt [PATCH 3/6] reg: Add wchar/type conversion functions
107259NewJonathan Vollebregt [PATCH 2/6] reg: Add path/key conversion functions
107254NewJonathan Vollebregt [PATCH 1/6] reg: Sanitize key paths in mainOK9776
107241Other projectMathew Hodson [tools] patches: Prevent the green color of OK testbot jobs from being overridden.
107240RejectedDan Bassi comctl32: Use strcmpW instead of pointer comparison to ensure treeview updates correctly (try 2)OK9756
107237Test failureShuai Meng [PATCH] vbscript: Implemented String(try 2)Failed9751
107223SupersededHao Peng[PATCH] mshtml: check null before release the elem object
107219NewStefan Dösinger [PATCH 3/5] ddraw/tests: RestoreDisplayMode uses the registry mode.Failed9733
107207NewBruno Jesus [2/2] ws2_32: Properly implement SO_CONNECT_TIME (try 3)Failed9727
107208RejectedBruno Jesus [1/2] server: Store the time of the socket connection (resend)
107204RejectedAndré Hentschel d3dx10_43: Add stub for D3DXCpuOptimizations
107177NewDavid Heidelberger [RFC] dbghelp: implement DW_TAG_unspecified_type
107176NewAlistair Leslie-Hughes dpnet: Check if DirectDplay is installed (try 4 - resend)OK9691
107131NewAlex Henrie [PATCH 4/4] kernel32/tests: Add UTF-7 encoded surrounding characters tests.OK9628
107132NewAlex Henrie [PATCH 3/4] kernel32/tests: Add UTF-7 non-encoded surrounding characters tests.OK9627
107130NewAlex Henrie [PATCH 2/4] kernel32/tests: Add complex UTF-7 encoding tests.OK9626
107129NewAlex Henrie [PATCH 1/4] kernel32/tests: Add simple UTF-7 encoding tests.OK9625
107123NewJonathan Vollebregt [v5 12/12] reg.exe: Implement query functionality
107092NewDavide Pizzetti Italian translation of Wine
107067NewSebastian Lackner [3/3] advapi32/tests: Add additional tests for passing a thread sd to CreateProcess.OK9542
107066NewSebastian Lackner [2/3] kernel32: Implement passing security descriptors from CreateProcess to the wineserver.OK9541
107065PendingSebastian Lackner [1/3] server: Support for thread and process security descriptors in new_process wineserver call.
107062NewStefan Dösinger [PATCH 4/4] d3d9/tests: Port test_window_style to d3d9ex.Failed9534
107060NewStefan Dösinger [PATCH 3/4] d3d9/tests: Port wndproc tests to d3d9ex.Failed9533
107059NewStefan Dösinger [PATCH 2/4] d3d9/tests: Avoid mode changes in d3d9ex' test_lost_device.Failed9532
107057PendingAndré Hentschel ieframe/tests: Skip when IWebBrowser2 interface is not availableOK9528
107043PendingAndré Hentschel advapi32/tests: Don't crash on Wine in WoW setupsFailed9509
107041NewErich E. Hoover[PATCH 5/5] ntdll: Implement storing DOS attributes in NtCreateFile.Failed9506
107040NewErich E. Hoover[PATCH 4/5] ntdll: Implement storing DOS attributes in NtSetInformationFile.Failed9505
107039NewErich E. Hoover[PATCH 3/5] ntdll: Implement retrieving DOS attributes in NtQuery[Full]AttributesFile and NtQueryDirectoryFile.
107038NewErich E. Hoover[PATCH 2/5] ntdll: Implement retrieving DOS attributes in NtQueryInformationFile.
107037NewErich E. Hoover[PATCH 1/5] ntdll: Unify retrieving the attributes of a file.
107036NewErich E. Hoover[PATCH 1/1] ddraw: Return the primary legacy ddraw device last.OK9504
107033NewHans Leidekker wininet: Remove the content length header after the request is sent.
107032NewHans Leidekker ieframe: Send command state change notifications from history navigation handlers.Failed9497
107031NewHugh McMaster cmd/tests: Spelling and grammar fixesFailed9495
107013NewHao Peng[PATCH] mshtml/tests: fix warnings by coverity on put search testOK9463
107000NewMatteo Bruni [PATCH 6/6] wined3d: Don't replicate shader limits values for each shader.
106998NewMatteo Bruni [PATCH 5/6] d3d9/tests: Port the unsupported shaders test to D3D9Ex.OK9404
106969NewStefan Dösinger [PATCH 2/2] d3d8/tests: Avoid follow-up errors if resetting the device fails.OK9362
106968NewStefan Dösinger [PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.Failed9361
106939NewZhenbo Li shell32: fix a test failure in shlfileop.cOK9332
106935NewStefan Dösinger [PATCH 3/3] d3d8/tests: Introduce a create_device_pp function for custom present parameters.Failed9329
106936NewStefan Dösinger [PATCH 2/3] d3d9/tests: Introduce a create_device_pp function for custom present parameters.OK9328
106933NewBernhard Reiter imagehlp: Implement (parts of) BindImageEx (try 12)OK9325
106902NewStefan Dösinger [PATCH 7/7] user32/tests: Test WM_SYSCOMMAND(SC_MINIMIZE) on an unminimizable window.Failed9283
106901NewStefan Dösinger [PATCH 6/7] user32/tests: Test minimizing an unminimizable window. (v2)Failed9282
106900NewStefan Dösinger [PATCH 5/7] d3d8/tests: Test messages on focus loss (v3).Failed9281
106897NewStefan Dösinger [PATCH 4/7] d3d9/tests: Port test_wndproc to d3d9ex (v2).OK9280
106899NewStefan Dösinger [PATCH 3/7] d3d9/tests: Test messages on focus loss (v3).OK9279
106896NewStefan Dösinger [PATCH 2/7] wined3d: Restore the display mode on focus loss (v2).
106898NewStefan Dösinger [PATCH 1/7] wined3d: Minimize device windows on focus loss (v2).
106865NewSebastian Lackner [2/4] advapi: Trigger write watches before passing userdata pointer to read syscall.
106839NewJoachim Priesner [PATCH 3/3] comctl32: Implement the TaskDialog function (try 2)OK9206
106841PendingJoachim Priesner [PATCH 2/3] comctl32: Basic implementation of TaskDialogIndirect (try 2)
106840PendingJoachim Priesner [PATCH 1/3] comctl32: Move TaskDialogIndirect function to separate file (try 2)
106776SupersededJactry Zeng [PATCH 3/3] riched20: Add IID_IRichEditOle and IID_ITextDocument support for ITextServices::QueryInterface. (rebase & resend)OK9136
106775SupersededJactry Zeng [PATCH 2/3] riched20: Add COM aggregation support for IRichEditOle. (try 3)


StatusPossible causes
  • Patch not even looked at yet, there's still hope...
  • The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help.
  • Waiting for feedback from the main developer in that area.
  • You have done everything right; congratulations!
  • You screwed up but AJ missed it, send a fix before someone notices ;-)
  • The patch is part of a series in which a previous patch hasn't been applied. Resend when the dependent patch is fixed.
Bad sequence
  • The patch is part of a series but it's not correctly numbered. Resend the series with correct sequence numbers to enable the testbot to figure it out.
  • An updated version of the patch has been submitted.
  • Someone else fixed the problem already.
Needs tests
  • You need to write some test cases demonstrating that the patch is correct.
  • The patch is deferred because of code freeze for an upcoming release. Either resend after the release, make the patch less intrusive, or make a convincing argument that it needs to be included in the release.
Other project
  • The patch belongs to another WineHQ project (website, appdb, etc.) and will be applied by the respective maintainer.
Apply failure
  • The patch got mangled in transit.
  • It's not relative to the latest git.
  • Someone else sent a patch that changes the same area and causes conflicts.
  • The patch is relative to a subdirectory (using 'git format-patch' is strongly recommended).
Build failure
  • Syntax error or other compile problem.
  • You forgot to include some changes or new files required for compilation.
  • The patch causes compiler warnings (maintainer mode implies -Werror).
  • The patch author's full name or email address are incorrect or missing.
  • Whitespace got mangled in transit.
  • Indentation is messed up (usually from editing with a non-standard tab size).
  • 8-bit chars got mangled in transit (usually when sending patches to resource files).
  • You are making gratuitous formatting changes to the code.
  • You are using C++ comments.
No patch
  • You hit 'send' before attaching the patch.
  • The mail is a reply to another patch, or spam.
  • The patch has been rejected with a comment on wine-devel or #winehackers.
  • The patch contains an obvious error that you are expected to figure out yourself.
Needs splitting
  • A single mail contained multiple patch files.
  • The patch contains unrelated changes that should be sent as separate patches.
  • The patch is simply too large for review, you need to find a way to split it.
Test failure
  • You didn't run 'make test' before submitting.
  • The patch requires a Wine fix but doesn't use todo_wine.
  • The patch fixes a failure but doesn't remove the corresponding todo_wine.
  • The testbot detected new failures on Windows.