From: "Matteo Bruni (@Mystral)" <wine@gitlab.winehq.org>
Subject: Re: [PATCH 0/3] MR332: d3dx10: Support creating effect from pre-built shader
Message-Id: <wine-wine-mr332-v1-note3140@gitlab-mail-bridge>
Date: Fri, 01 Jul 2022 19:25:08 +0000
In-Reply-To: <wine-wine-mr332-v1@gitlab-mail-bridge>
References: <merge_request_409@gitlab.winehq.org> <wine-wine-mr332-v1@gitlab-mail-bridge>

Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/tests/d3dx10.c:
>      return buffer;
>  }
>  
> +BOOL load_resource(HMODULE module, const WCHAR *resource, void **data, DWORD *size)
> +{
> +    HGLOBAL hglobal;
> +    HRSRC rsrc;
> +
> +    if (!(rsrc = FindResourceW(module, resource, (const WCHAR *)RT_RCDATA)) ||
> +            !(*size = SizeofResource(module, rsrc)) ||
> +            !(hglobal = LoadResource(module, rsrc)) ||
> +            !(*data = LockResource(hglobal)))
I've got a bunch of nitpicks...

We usually put the binary operator at the start of the next line in these cases:

```suggestion:-3+0
    if (!(rsrc = FindResourceW(module, resource, (const WCHAR *)RT_RCDATA))
            || !(*size = SizeofResource(module, rsrc))
            || !(hglobal = LoadResource(module, rsrc))
            || !(*data = LockResource(hglobal)))
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/332#note_3140