From: Piotr Caban <wine@gitlab.winehq.org>
Subject: [PATCH v5 03/11] d3dx10/tests: Fix texture leak in check_resource_data.
Message-Id: <wine-wine-mr272-v5-patch3@gitlab-mail-bridge>
Date: Fri, 01 Jul 2022 18:01:04 +0000
In-Reply-To: <wine-wine-mr272-v5@gitlab-mail-bridge>
References: <merge_request_341@gitlab.winehq.org> <wine-wine-mr272-v5@gitlab-mail-bridge>

From: Piotr Caban <piotr@codeweavers.com>

Signed-off-by: Piotr Caban <piotr@codeweavers.com>
---
 dlls/d3dx10_43/tests/d3dx10.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/dlls/d3dx10_43/tests/d3dx10.c b/dlls/d3dx10_43/tests/d3dx10.c
index c0c14ef592c..c9bdf90eaf4 100644
--- a/dlls/d3dx10_43/tests/d3dx10.c
+++ b/dlls/d3dx10_43/tests/d3dx10.c
@@ -1237,7 +1237,7 @@ static void check_resource_data(ID3D10Resource *resource, const struct test_imag
     ok_(__FILE__, line)(hr == S_OK, "Map failed, hr %#lx.\n", hr);
     if (hr != S_OK)
     {
-        ID3D10Texture2D_Unmap(readback, 0);
+        ID3D10Texture2D_Release(readback);
         return;
     }
 
@@ -1253,6 +1253,7 @@ static void check_resource_data(ID3D10Resource *resource, const struct test_imag
     }
 
     ID3D10Texture2D_Unmap(readback, 0);
+    ID3D10Texture2D_Release(readback);
 }
 
 static void test_D3DX10UnsetAllDeviceObjects(void)
@@ -2078,7 +2079,7 @@ static void test_D3DX10CreateAsyncTextureProcessor(void)
 
     CoUninitialize();
 
-    ID3D10Device_Release(device);
+    ok(!ID3D10Device_Release(device), "Unexpected refcount.\n");
 }
 
 static void test_get_image_info(void)
@@ -2433,7 +2434,7 @@ static void test_create_texture(void)
 
     CoUninitialize();
 
-    ID3D10Device_Release(device);
+    ok(!ID3D10Device_Release(device), "Unexpected refcount.\n");
 }
 
 #define check_rect(rect, left, top, right, bottom) _check_rect(__LINE__, rect, left, top, right, bottom)

-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/272