From: "RĂ©mi Bernon (@rbernon)" Subject: Re: [PATCH 0/5] MR355: win32u: Move more display mode logic out of graphics drivers. Message-Id: Date: Fri, 01 Jul 2022 09:27:23 +0000 In-Reply-To: References: On Fri Jul 1 07:46:55 2022 +0000, Zhiyi Zhang wrote: > I think you can remove CDS_UPDATEREGISTRY here. Otherwise, > user_driver->pChangeDisplaySettingsEx() will try to find the full mode again. Yes, though as you spotted below we'd need to keep the driver extra data around in that case. Ultimately I intend to store the driver extra in registry blob as well, and cache it in win32u. The first `pChangeDisplaySettingsEx` call would be replaced by a win32u-side full mode lookup, then passed to the actual `pChangeDisplaySettingsEx` call. But we don't have the mode list there yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/355#note_3103