From: "Rémi Bernon (@rbernon)" <wine@gitlab.winehq.org>
Subject: Re: [PATCH 0/5] MR355: win32u: Move more display mode logic out of graphics drivers.
Message-Id: <wine-wine-mr355-v1-note3094@gitlab-mail-bridge>
Date: Fri, 01 Jul 2022 07:22:55 +0000
In-Reply-To: <wine-wine-mr355-v1@gitlab-mail-bridge>
References: <merge_request_434@gitlab.winehq.org> <wine-wine-mr355-v1@gitlab-mail-bridge>

On Fri Jul  1 07:10:03 2022 +0000, Zhiyi Zhang wrote:
> You should move this memcpy() before pthread_mutex_unlock().
It's copying from the local `mode` variable, which has been copied from the cached modes within the mutex already. It's a bit redundant but I used the local variable for ENUM_CURRENT_SETTINGS.

It's pretty much temporary anyway as I intend to move the existing mode enumeration to win32u entirely later and only keep ENUM_CURRENT_SETTINGS in the drivers.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/355#note_3094