From: "eric pouech (@epo)" <wine@gitlab.winehq.org>
Subject: Re: [PATCH 0/1] MR352: cmd: Don't loop infinitely on NUL.
Message-Id: <wine-wine-mr352-v1-note3065@gitlab-mail-bridge>
Date: Thu, 30 Jun 2022 17:00:44 +0000
In-Reply-To: <wine-wine-mr352-v1@gitlab-mail-bridge>
References: <merge_request_431@gitlab.winehq.org> <wine-wine-mr352-v1@gitlab-mail-bridge>

I tested some more on my side, and it's not what I expected :-(
https://testbot.winehq.org/JobDetails.pl?Key=117992

these tests need to be extended (cannot tell which one of the two new tests display nothing) (likely the contents1 displays nothing and for contents2 printf doesn't print the ctrl-z character)

anyway, I tried also to run this simple batch on windows:
`"echo\necho\0\echo"`
and it hangs after printing the first 'echo on' (so \0 isn't a generic EOF marker)

so changing WCMD_fgets when running into \0 to return EOF isn't likely the right solution (at least as a generic solution) (and I still don't like in case of "abc\0" not returning the "abc" characters)

more tests are needed :-(

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/352#note_3065