From: "Andrew Eikum (@aeikum)" <wine@gitlab.winehq.org>
Subject: Re: [PATCH 0/1] MR338: mmdevapi: Override product strings for DualSense controller audio devices
Message-Id: <wine-wine-mr338-v1-note2953@gitlab-mail-bridge>
Date: Wed, 29 Jun 2022 13:40:34 +0000
In-Reply-To: <wine-wine-mr338-v1@gitlab-mail-bridge>
References: <merge_request_415@gitlab.winehq.org> <wine-wine-mr338-v1@gitlab-mail-bridge>

Andrew Eikum (@aeikum) commented about dlls/mmdevapi/devenum.c:
>          if (!RegCreateKeyExW(key, L"Properties", 0, NULL, 0, KEY_WRITE|KEY_READ|KEY_WOW64_64KEY, NULL, &keyprop, NULL))
>          {
>              PROPVARIANT pv;
> +            pv.pwszVal = NULL;
> +
> +            if (SUCCEEDED(drvs.pGetPropValue(id, &devicepath_key, &pv))) {
Not all drivers implement GetPropValue, so you can't unconditionally call it. `set_driver_prop_value` could maybe use a refactor so this doesn't get messy.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/338#note_2953