From: "Andrew Eikum (@aeikum)" <wine@gitlab.winehq.org>
Subject: Re: [PATCH 0/1] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod
Message-Id: <wine-wine-mr337-v1-note2948@gitlab-mail-bridge>
Date: Wed, 29 Jun 2022 13:21:31 +0000
In-Reply-To: <wine-wine-mr337-v1@gitlab-mail-bridge>
References: <merge_request_414@gitlab.winehq.org> <wine-wine-mr337-v1@gitlab-mail-bridge>

On a style note, please consistently use 4-space indents. There's also an unnecessary diff in `pulse_add_device`.

I'd also suggest falling back to the default format, in the case where the unix call fails for some reason. But maybe there's a good reason to prefer failing?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_2948