From: "Rémi Bernon (@rbernon)" <wine@gitlab.winehq.org>
Subject: Re: [PATCH v3 0/4] MR313: win32u: Finish moving raw input APIs.
Message-Id: <wine-wine-mr313-v3-note2887@gitlab-mail-bridge>
Date: Tue, 28 Jun 2022 17:24:15 +0000
In-Reply-To: <wine-wine-mr313-v3@gitlab-mail-bridge>
References: <merge_request_387@gitlab.winehq.org> <wine-wine-mr313-v3@gitlab-mail-bridge>

On Tue Jun 28 16:55:07 2022 +0000, **** wrote:
> Zebediah Figura replied on the mailing list:
> ```
> On 6/28/22 02:10, Rémi Bernon (@rbernon) wrote:
> > Rémi Bernon (@rbernon) commented about dlls/wow64win/user.c:
> >> +
> >> +    if (size != sizeof(RAWINPUTDEVICELIST32))
> >> +    {
> >> +        SetLastError( ERROR_INVALID_PARAMETER );
> >> +        return ~0u;
> >> +    }
> >> +
> >> +    if (devices32)
> >> +    {
> >> +        RAWINPUTDEVICELIST *devices64;
> >> +        unsigned int ret, i;
> >> +
> >> +        if (!(devices64 = Wow64AllocateTemp( (*count) *
> sizeof(*devices64) )))
> >> +        {
> >> +            SetLastError( ERROR_NOT_ENOUGH_MEMORY );
> >> +            return FALSE;
> > This should be ~0u.
> > 
> The bridge doesn't give me any context on which commit is being 
> responded to (is it not possible to reconstruct that information?) but 
> RegisterRawInputDevices() returns BOOL, so one of those three is correct.
> The other two are errors; thanks for finding them. I've resent a new 
> version with them fixed.
> ```
It's in wow64_NtUserGetRawInputDeviceList, in PATCH 3.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/313#note_2887