From: Zebediah Figura <zfigura@codeweavers.com>
Subject: Re: [PATCH v2 0/4] MR313: win32u: Finish moving raw input APIs.
Message-Id: <7fd39875-ff08-ac4c-5d6f-eda138b6df99@codeweavers.com>
Date: Tue, 28 Jun 2022 11:54:54 -0500
In-Reply-To: <wine-wine-mr313-v2-note2842@gitlab-mail-bridge>
References: <merge_request_387@gitlab.winehq.org> <wine-wine-mr313-v2@gitlab-mail-bridge> <wine-wine-mr313-v2-note2842@gitlab-mail-bridge>

On 6/28/22 02:10, Rémi Bernon (@rbernon) wrote:
> Rémi Bernon (@rbernon) commented about dlls/wow64win/user.c:
>> +
>> +    if (size != sizeof(RAWINPUTDEVICELIST32))
>> +    {
>> +        SetLastError( ERROR_INVALID_PARAMETER );
>> +        return ~0u;
>> +    }
>> +
>> +    if (devices32)
>> +    {
>> +        RAWINPUTDEVICELIST *devices64;
>> +        unsigned int ret, i;
>> +
>> +        if (!(devices64 = Wow64AllocateTemp( (*count) * sizeof(*devices64) )))
>> +        {
>> +            SetLastError( ERROR_NOT_ENOUGH_MEMORY );
>> +            return FALSE;
> This should be ~0u.
> 

The bridge doesn't give me any context on which commit is being 
responded to (is it not possible to reconstruct that information?) but 
RegisterRawInputDevices() returns BOOL, so one of those three is correct.

The other two are errors; thanks for finding them. I've resent a new 
version with them fixed.