From: "Nikolay Sivov (@nsivov)" <wine@gitlab.winehq.org>
Subject: Re: [PATCH 0/3] MR330: Tests for properties.
Message-Id: <wine-wine-mr330-v1-note2848@gitlab-mail-bridge>
Date: Tue, 28 Jun 2022 07:57:21 +0000
In-Reply-To: <wine-wine-mr330-v1@gitlab-mail-bridge>
References: <merge_request_407@gitlab.winehq.org> <wine-wine-mr330-v1@gitlab-mail-bridge>

Nikolay Sivov (@nsivov) commented about dlls/d2d1/tests/d2d1.c:
>      }
>      effect_tests[] =
>      {
> -        {&CLSID_D2D12DAffineTransform,       1, 1, 1, 1},
> -        {&CLSID_D2D13DPerspectiveTransform,  1, 1, 1, 1},
> -        {&CLSID_D2D1Composite,               1, 2, 1, 0xffffffff},
> -        {&CLSID_D2D1Crop,                    1, 1, 1, 1},
> -        {&CLSID_D2D1Shadow,                  1, 1, 1, 1},
> -        {&CLSID_D2D1Grayscale,               3, 1, 1, 1},
> +        {&CLSID_D2D12DAffineTransform,       1, 4, 1, 1, 1},
> +        {&CLSID_D2D13DPerspectiveTransform,  1, 8, 1, 1, 1},
> +        {&CLSID_D2D1Composite,               1, 1, 2, 1, 0xffffffff},
> +        {&CLSID_D2D1Crop,                    1, 2, 1, 1, 1},
> +        {&CLSID_D2D1Shadow,                  1, 3, 1, 1, 1},
> +        {&CLSID_D2D1Grayscale,               3, 0, 1, 1, 1},
> +    };
I don't think it's very convenient to test a bunch of builtin effects at once. We won't have them implemented at the same time, so that will require more skips/todos. It's better to have that tested in per-effect functions, like test_effect_2d_affine().

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/330#note_2848