From: Austin English Subject: Re: [PATCH] include: Add dxcore.idl. Message-Id: Date: Sat, 25 Jun 2022 02:41:36 -0500 In-Reply-To: <2464B00E-9E78-4215-A0CD-7995E3D036C3@gmail.com> References: <2464B00E-9E78-4215-A0CD-7995E3D036C3@gmail.com> On Sat, Jun 25, 2022 at 2:15 AM Stefan Dösinger wrote: > > > Am 25.06.2022 um 08:47 schrieb Charles Davis : > > > > On Sat, Jun 25, 2022 at 12:36 AM Biswapriyo Nath > wrote: > >> > >> Thank you for the review. I copied it from dxcore.h[1]. I have > >> attached the updated patch. > >> > >> [1]: > https://github.com/microsoft/DirectX-Headers/blob/main/include/directx/dxcore.h > > > > Ah, so it is under an open-source license compatible with ours. I was > > concerned you might have copy-pasted out of a header with a more > > restrictive license. (Even if it were Apache, for example, that would > > cause legal problems, because that license infamously *isn't* > > compatible with the GPLv2.) Sorry about that. > > At very least the Microsoft Corp copyright line should be retained in this > case. > > The dos and don'ts of writing headers have always been tricky and > frustrating. > Not trying to 'volunteer' you for this (I think the default person for that is jwhite ;) ) but sounds like a great chance to discuss/clarify/document this. > I think this is the first case where we have the luxury of a > license-compatible header from Microsoft. > FYI, several things have been open sourced with compatible licenses recently. I.e., a search on github shows 1000+ projects with MIT licenses from Microsoft: https://github.com/orgs/microsoft/repositories?q=license%3Amit -- -Austin GPG: 267B CC1F 053F 0749 (expires 2024/02/17)
On Sat, Jun 25, 2022 at 2:15 AM Stefan Dösinger <stefandoesinger@gmail.com> wrote:

> Am 25.06.2022 um 08:47 schrieb Charles Davis <cdavis5x@gmail.com>:
>
> On Sat, Jun 25, 2022 at 12:36 AM Biswapriyo Nath <nathbappai@gmail.com> wrote:
>>
>> Thank you for the review. I copied it from dxcore.h[1]. I have
>> attached the updated patch.
>>
>> [1]: https://github.com/microsoft/DirectX-Headers/blob/main/include/directx/dxcore.h
>
> Ah, so it is under an open-source license compatible with ours. I was
> concerned you might have copy-pasted out of a header with a more
> restrictive license. (Even if it were Apache, for example, that would
> cause legal problems, because that license infamously *isn't*
> compatible with the GPLv2.) Sorry about that.

At very least the Microsoft Corp copyright line should be retained in this case.

The dos and don'ts of writing headers have always been tricky and frustrating.

Not trying to 'volunteer' you for this (I think the default person for that is jwhite ;) ) but sounds like a great chance to discuss/clarify/document this.
 
I think this is the first case where we have the luxury of a license-compatible header from Microsoft.

FYI, several things have been open sourced with compatible licenses recently. I.e., a search on github shows 1000+ projects with MIT licenses from Microsoft:
https://github.com/orgs/microsoft/repositories?q=license%3Amit

--
-Austin
GPG: 267B CC1F 053F 0749 (expires 2024/02/17)