From: Ziqing Hui <zhui@codeweavers.com>
Subject: Re: [PATCH 2/5] d2d1: Partially implement RegisterEffectFromStream().
Message-Id: <e039ab14-6889-cb33-ce2d-764e18a8b9d0@codeweavers.com>
Date: Tue, 7 Jun 2022 11:54:41 +0800
In-Reply-To: <e1cd45ef-ec32-5e07-7754-f16ebc515a70@codeweavers.com>
References: <20220606073525.1774002-1-zhui@codeweavers.com> <20220606073525.1774002-2-zhui@codeweavers.com> <e6add160-d761-1675-0ac9-5e76ade56cf9@codeweavers.com> <89f35236-b39e-065f-13a6-c30a7baa74cc@codeweavers.com> <e1cd45ef-ec32-5e07-7754-f16ebc515a70@codeweavers.com>



On 6/7/22 11:43 AM, Ziqing Hui wrote:
> 
>>>> +    reg->info->default_input_count = input_count;
>>>> +    reg->info->min_inputs = input_count;
>>>> +    reg->info->max_inputs = input_count;
>>> Is this supposed to be subproperties of an Input? Maybe we should have basic property support first, and store it there. Is min/max/default expressible in effect xml? <Input> attributes maybe?
>>
>> It is likely that they can be expressed in xml as properties of <Effect> like "DisplayName"/"Author", tests are still needed. 
>> And according to the current test, if I don't explicitly express them in xml, they will be equal to the number of <Input> nodes inside <Inputs>.
>>
> 
> I did some tests today. I didn't find a way to express min/max/default input count in XML.
> 
> I tried these ways:
> 
> * Property of <Effect>:
> 
>     <Effect>
>         ...
>         <Property name='MinInputs' type='uint32' value='1'/>
>     </Effect>
> 
> * Sub property of <Inputs>:
> 
>     <Effect>
>         ...
>         <Inputs>
>             <Property name='Min' type='uint32' value='1'/>
>         </Inputs>
>     <Effect>
> 
> * Attribute of <Inputs>:
> 
>     <Effect>
>         ...
>         <Inputs min='1'/>
>     <Effect/>
> 
> Unfortunately, none of them work.
> 
> 

Some typo here in the mail... the second effect nodes are all </Effect>.