From: Alex Henrie Subject: Re: [PATCH] include: Allow making Wine Server requests from C++ code Message-Id: Date: Mon, 6 Jun 2022 11:14:00 -0600 In-Reply-To: References: <20220603161556.3773472-1-tayarani@google.com> <703FD65F-01F0-414A-A4ED-7D096D0438C9@gmail.com> On Mon, Jun 6, 2022 at 10:12 AM Mahdi Tayarani wrote: > > We have an input processing system which requires us to directly send input update information to the Wine Server. The existing helper methods don't provide what we need. Does that mean that you're porting Wine to a new platform and writing something like winex11.drv for that platform? Could your new code be included in upstream Wine one day? If so, it would probably be better to write it in C instead of C++ because the Wine project does not currently accept C++ code. Or do you mean that you are writing cross-platform software that will run on both Windows and on Wine? If that is the case, how does the code work on Windows? Could the same functions that you call on Windows be improved in Wine to do what you need? > Can you please elaborate why it will be a tough sell? The change provides no sort of functional or behavioural change. It's just making the cast that was already implicitly happening, explicit. Although the change itself is very small, it smells like a hack, and the Wine community really does not like hacks. I think everyone would prefer to identify the underlying problem here and, if possible, resolve it instead of working around it. That said, I am just a volunteer Wine developer trying to be helpful; other developers would be able to speak more authoritatively. -Alex