From: Mahdi Tayarani <tayarani@google.com>
Subject: Re: [PATCH] include: Allow making Wine Server requests from C++ code
Message-Id: <CAEf0Gvg0s5sdCbAH84a0+=43z0yb62dXpo3EPL4xHKE1W647fw@mail.gmail.com>
Date: Mon, 6 Jun 2022 12:12:44 -0400
In-Reply-To: <CAMMLpeT3YfLC+zcMbUAWcVYXJeWzrhR1fXDipbaPAiBFpWVMvA@mail.gmail.com>
References: <20220603161556.3773472-1-tayarani@google.com> <703FD65F-01F0-414A-A4ED-7D096D0438C9@gmail.com> <CAEf0Gvis5xNqp6X=4VPM3r+NY5nqi-5Q0PGKB4MoojKKwJ2Dxg@mail.gmail.com> <CAMMLpeT3YfLC+zcMbUAWcVYXJeWzrhR1fXDipbaPAiBFpWVMvA@mail.gmail.com>

We have an input processing system which requires us to directly send input
update information to the Wine Server. The existing helper methods don't
provide what we need.

Can you please elaborate why it will be a tough sell? The change provides
no sort of functional or behavioural change. It's just making the cast that
was already implicitly happening, explicit.

On Mon, Jun 6, 2022 at 11:51 AM Alex Henrie <alexhenrie24@gmail.com> wrote:

> On Mon, Jun 6, 2022 at 8:59 AM Mahdi Tayarani <tayarani@google.com> wrote:
> >
> > We need to include "include/wine/server.h" as it contains the definition
> for the SERVER_START_REQ/SERVER_END_REQ macros. Our code (written in C++)
> needs to make a Wine Server call so we have to include that header. But by
> doing so we run into compilation issues.
>
> I suspect that this is going to be a tough sell. Why are you trying to
> call the Wineserver directly, instead of calling the Windows function
> that calls the Wineserver?
>
> -Alex
>

<div dir="ltr">We have an input processing system which requires us to directly send input update information to the Wine Server. The existing helper methods don&#39;t provide what we need.<div><br></div><div>Can you please elaborate why it will be a tough sell? The change provides no sort of functional or behavioural change. It&#39;s just making the cast that was already implicitly happening, explicit.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 6, 2022 at 11:51 AM Alex Henrie &lt;<a href="mailto:alexhenrie24@gmail.com">alexhenrie24@gmail.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Jun 6, 2022 at 8:59 AM Mahdi Tayarani &lt;<a href="mailto:tayarani@google.com" target="_blank">tayarani@google.com</a>&gt; wrote:<br>
&gt;<br>
&gt; We need to include &quot;include/wine/server.h&quot; as it contains the definition for the SERVER_START_REQ/SERVER_END_REQ macros. Our code (written in C++) needs to make a Wine Server call so we have to include that header. But by doing so we run into compilation issues.<br>
<br>
I suspect that this is going to be a tough sell. Why are you trying to<br>
call the Wineserver directly, instead of calling the Windows function<br>
that calls the Wineserver?<br>
<br>
-Alex<br>
</blockquote></div>