From: "Zebediah Figura (she/her)" <zfigura@codeweavers.com>
Subject: Re: [PATCH 1/3] wined3d: Handle discarded buffers in buffer_resource_sub_resource_map().
Message-Id: <7603cb99-cbe7-2e48-86e0-76b634c84ef1@codeweavers.com>
Date: Thu, 27 Jan 2022 11:11:11 -0600
In-Reply-To: <CAOsNvwxJwGLAudQ-BhkdOHWWrqk6hd5nga-awtxZ5EJCROfvXA@mail.gmail.com>
References: <20220125022039.2005817-1-zfigura@codeweavers.com> <CAOsNvwxB_o4LrJjgb0dbFRiZofyKX7_Cwe0OpajCqz2ZDPh2nA@mail.gmail.com> <2cfd1f6b-913b-b7bb-a4fa-2cf750f180f8@codeweavers.com> <CAOsNvwxJwGLAudQ-BhkdOHWWrqk6hd5nga-awtxZ5EJCROfvXA@mail.gmail.com>

On 1/27/22 07:13, Henri Verbeet wrote:
>>> What is the issue exactly? Is it that buffer->buffer_object may not
>>> have been created yet for discarded resources?
>>
>> More generally, no location may yet have been prepared. In particular
>> after patch 3/3 no location will be prepared on creation.
> 
> It probably makes sense to check for WINED3D_BUFFER_USE_BO instead of
> buffer->buffer_object then, and add wined3d_buffer_prepare_location()
> calls to paths that don't already call wined3d_buffer_load_location().

Sure, that makes sense.