From: Piotr Caban Subject: Re: [PATCH 6/6] msvcp140_atomic_wait: Implement __std_bulk_submit_threadpool_work. Message-Id: Date: Thu, 27 Jan 2022 17:03:17 +0100 In-Reply-To: References: <27c54241-0aa7-6094-6f00-def4230762a5@gmail.com> On 1/27/22 16:04, Daniel Lehman wrote: >> The workcalled < 1234 occasionally fails on my machine (and if it doesn't we end with workcalled around 1230). Please remove the test or find a way to avoid the race. > I wanted a way to show the 2nd argument was really a cancel, but wasn't sure about the best way. the 1234 seemed to work consistently for my box - would a higher number be ok? if not, would removing the test for now be ok, to avoid random failures? I don't really like increasing the number - it seems fragile and the number is already quite big. I think it's better to remove the test. You can also add Sleep in callback but it's not the nicest solution either.