From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH vkd3d v2] build: Disable crosstests as well if tests are disabled.
Message-Id: <CAOsNvwyaEdFKO_JGnrPzsuhHbPaPQPdMf8cWtXaZtuSaiss6dA@mail.gmail.com>
Date: Thu, 27 Jan 2022 15:54:57 +0100
In-Reply-To: <20220126173551.2592046-1-zfigura@codeweavers.com>
References: <20220126173551.2592046-1-zfigura@codeweavers.com>

On Wed, 26 Jan 2022 at 18:36, Zebediah Figura <zfigura@codeweavers.com> wrote:
>
> Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
> ---
> v2: Actually disable them in the makefile.
>
>  Makefile.am  | 10 ++++++++++
>  configure.ac |  9 +++++----
>  2 files changed, 15 insertions(+), 4 deletions(-)
>
If the goal is just to disable the crosstest targets, wouldn't
inserting something like

    AS_IF([test "x$enable_tests" = "xno"], [CROSSTARGET32=no CROSSTARGET64=no])

before CROSSTARGET32/CROSSTARGET64 are used be a little more
straightforward? Alternatively, we could use the existing BUILD_TESTS
in Makefile.am and adjust the messages in configure.ac. Note however
that the crosstest targets also build the demos, not just the tests.