From: Connor McAdams Subject: Re: [PATCH 4/4] wdscore: Add stubs for WdsSetupLogMessage[AW]. Message-Id: <20220127043059.GA826117@connor-desktop> Date: Wed, 26 Jan 2022 23:30:59 -0500 In-Reply-To: <20220127040158.536209-4-mohamadaljaf@gmail.com> References: <20220127040158.536209-1-mohamadaljaf@gmail.com> <20220127040158.536209-4-mohamadaljaf@gmail.com> Hi Mohamad, just noticed something while giving this patch a look over: > diff --git a/dlls/wdscore/wdscore.spec b/dlls/wdscore/wdscore.spec > index 51e24d980fa..18de37d1ed7 100644 > --- a/dlls/wdscore/wdscore.spec > +++ b/dlls/wdscore/wdscore.spec > @@ -116,7 +116,7 @@ > @ stub WdsGetBlackboardValue > @ stub WdsGetCurrentExecutionGroup > @ stub WdsGetSetupLog > -@ stub WdsTempDir > +@ stub WdsGetTempDir > @ stub WdsInitialize > @ stub WdsInitializeCallbackArray > @ stub WdsInitializeDataBinary > @@ -139,7 +139,7 @@ > @ stub WdsPackCollection > @ stub WdsPublish > @ stub WdsPublishEx > -@ stub WdsPublishImmediateAsynch > +@ stub WdsPublishImmediateAsync > @ stub WdsPublishImmediateEx > @ stub WdsPublishOffline > @ stub WdsSeqAlloc The changes to 'WdsTempDir' and 'WdsPublishImmediateAsynch' seem unrelated to this patch. If they should be changed, this should probably be done in a separate patch.