From: "Zebediah Figura (she/her)" <zfigura@codeweavers.com>
Subject: Re: [PATCH] ws2_32: Increased MAX_SOCKETS_PER_PROCESS to 256
Message-Id: <55ee18ec-5306-906d-53d1-5d2a895eb4c6@codeweavers.com>
Date: Wed, 26 Jan 2022 16:15:08 -0600
In-Reply-To: <20220126171011.91967-1-andrewmiskell@mac.com>
References: <20220126171011.91967-1-andrewmiskell@mac.com>

Hello Andrew, thanks for the patch!

On 1/26/22 11:10, Andrew Miskell wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50352
> Signed-off-by: Andrew Miskell <andrewmiskell@mac.com>
> ---
>   dlls/ws2_32/socket.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c
> index fe7e4fb3464..004e386e5a8 100644
> --- a/dlls/ws2_32/socket.c
> +++ b/dlls/ws2_32/socket.c
> @@ -419,7 +419,7 @@ static BOOL socket_list_remove( SOCKET socket )
>       return FALSE;
>   }
>   
> -#define MAX_SOCKETS_PER_PROCESS      128     /* reasonable guess */
> +#define MAX_SOCKETS_PER_PROCESS      256     /* reasonable guess */
>   #define MAX_UDP_DATAGRAM             1024
>   static INT WINAPI WSA_DefaultBlockingHook( FARPROC x );
>   

Could you please add some tests for this, and in particular tests for 
different version numbers passed to WSAStartup()? A brief check suggests 
this isn't what modern Windows returns.

While you're at it, I think there's no reason to keep this in a #define
near the top of the file; it's only used in one place.