From: Georg Lehmann Subject: Re: [PATCH] winevulkan: Enable VK_EXT_pipeline_creation_feedback. Message-Id: <9e385f05-14d9-e822-3071-2079f67f9f7d@gmail.com> Date: Wed, 26 Jan 2022 18:02:38 +0100 In-Reply-To: References: <20220126163458.9611-1-dadschoorse@gmail.com> On 26.01.22 17:37, Henri Verbeet wrote: > On Wed, 26 Jan 2022 at 17:35, Georg Lehmann wrote: >> >> We did previously not support this extension because it runs into 32bit >> alignment issues. But it is core in 1.3, so we already enabled the >> functionality. Additionally vkd3d-proton wants to use the extension and it >> does not care about 32bit. >> > Shouldn't that have blocked 1.3 support instead? Maybe. 32bit winevulkan has a ton of small issues, only exposing a non-broken subset is not really possible. E.g. VkPhysicalDeviceVulkan11Properties is also broken due to alignment and we don't ignore invalid pointers in a lot of situations where we should. We would not even be conformant for 1.0 without any extensions. I think the best policy is to make everything work that is actually needed, there aren't a ton of 32bit Vulkan applications. It's mostly dxvk and possibly wined3d in the future as far as I understand. The issue with VK_EXT_pipeline_creation_feedback will result in a misreported compile time duration, which is pretty minor in my opinion.