From: Marvin Subject: Re: [PATCH 2/2] ddraw/tests: Don't insist on a different refresh rate if no refresh rate was requested. Message-Id: Date: Wed, 26 Jan 2022 05:11:10 -0600 In-Reply-To: <20220126085226.92315-2-stefan@codeweavers.com> References: <20220126085226.92315-2-stefan@codeweavers.com> Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106025 Your paranoid android. === w864 (64 bit report) === ddraw: ddraw2.c:3582: Test failed: Failed to create surface, hr 0x887601c2. 0b2c:ddraw2: unhandled exception c0000005 at 00000000004805F8 === w1064v1809 (32 bit report) === ddraw: ddraw7.c:18858: Test failed: Got unexpected color 0x00000040. === w1064_tsign (32 bit report) === ddraw: ddraw7.c:18858: Test failed: Got unexpected color 0x00000040. === debian11 (32 bit report) === ddraw: ddraw2.c:3974: Test failed: Got unexpected screen width 800. ddraw2.c:3976: Test failed: Got unexpected screen height 600. ddraw2.c:3981: Test failed: Got unexpected screen width 800. ddraw2.c:3983: Test failed: Got unexpected screen height 600. ddraw2.c:4005: Test failed: Got unexpected screen width 800. ddraw2.c:4007: Test failed: Got unexpected screen height 600. ddraw2.c:4040: Test failed: Got unexpected screen width 800. ddraw2.c:4042: Test failed: Got unexpected screen height 600. ddraw2.c:4063: Test failed: Got unexpected screen width 800. ddraw2.c:4065: Test failed: Got unexpected screen height 600. ddraw2.c:4070: Test failed: Got unexpected screen width 800. ddraw2.c:4072: Test failed: Got unexpected screen height 600. ddraw4.c:3612: Test failed: Expected (0,0)-(1024,768), got (0,0)-(640,480). ddraw4.c:3634: Test failed: Expected (0,0)-(1024,768), got (0,0)-(640,480). ddraw4.c:3660: Test failed: Expected (0,0)-(1024,768), got (0,0)-(640,480). ddraw4.c:3680: Test failed: Expected (0,0)-(1024,768), got (0,0)-(640,480). ddraw4.c:3716: Test failed: Expected (0,0)-(1024,768), got (0,0)-(640,480). === debian11 (32 bit Arabic:Morocco report) === ddraw: ddraw2.c:4070: Test failed: Got unexpected screen width 800. ddraw2.c:4072: Test failed: Got unexpected screen height 600. === debian11 (32 bit German report) === ddraw: ddraw4.c:3856: Test failed: Expected resolution 1024x768, got 720x480. ddraw4.c:3873: Test failed: Expected surface width 1024, got 720. ddraw4.c:3899: Test failed: Expected screen size 1024x768, got 720x480. ddraw4.c:3906: Test failed: Expected (0,0)-(1024,768), got (0,0)-(720,480). ddraw4.c:3918: Test failed: Expected surface width 1024, got 720. ddraw4.c:3920: Test failed: Expected surface height 768, got 480. ddraw4.c:3971: Test failed: Expected screen size 2 1024x768, got 720x480. ddraw4.c:3979: Test failed: Expected (0,0)-(1024,768), got (0,0)-(720,480). ddraw4.c:3991: Test failed: Expected surface width 1024, got 720. ddraw4.c:3993: Test failed: Expected surface height 768, got 480. === debian11 (32 bit French report) === ddraw: ddraw4.c:2956: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw4.c:2989: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw4.c:2992: Test failed: Expected window extended style 0x108, got 0x8. ddraw4.c:2998: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw4.c:3001: Test failed: Expected window extended style 0x108, got 0x8. ddraw4.c:3021: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw4.c:3023: Test failed: Expected window extended style 0x100, got 0. ddraw4.c:3040: Test failed: Expected (0,0)-(640,480), got (-32000,-32000)-(-31840,-31976). ddraw4.c:3063: Test failed: Expected (0,0)-(640,480), got (-32000,-32000)-(-31840,-31976). ddraw4.c:3083: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw4.c:3085: Test failed: Expected window extended style 0x100, got 0. ddraw7.c:3857: Test failed: Got unexpected screen width 800. ddraw7.c:3859: Test failed: Got unexpected screen height 600. ddraw7.c:3864: Test failed: Got unexpected screen width 800. ddraw7.c:3866: Test failed: Got unexpected screen height 600. ddraw7.c:3888: Test failed: Got unexpected screen width 800. ddraw7.c:3890: Test failed: Got unexpected screen height 600. ddraw7.c:3923: Test failed: Got unexpected screen width 800. ddraw7.c:3925: Test failed: Got unexpected screen height 600. ddraw7.c:3946: Test failed: Got unexpected screen width 800. ddraw7.c:3948: Test failed: Got unexpected screen height 600. ddraw7.c:3953: Test failed: Got unexpected screen width 800. ddraw7.c:3955: Test failed: Got unexpected screen height 600. === debian11 (32 bit Hebrew:Israel report) === ddraw: ddraw4.c:3464: Test failed: Got unexpected screen size 720x480. ddraw4.c:3518: Test failed: Expected message 0x47, but didn't receive it. ddraw4.c:3520: Test failed: Expected screen size 640x480, got 0x0. ddraw4.c:3526: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3550: Test failed: Expected surface width 640, got 720. ddraw4.c:3556: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3563: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3568: Test failed: Expected surface width 640, got 720. ddraw4.c:3583: Test failed: Expected surface width 640, got 720. ddraw4.c:3589: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3612: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3634: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3639: Test failed: Expected surface width 640, got 720. ddraw4.c:3660: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3680: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3693: Test failed: Expected resolution 640x480, got 720x480. ddraw4.c:3710: Test failed: Expected surface width 640, got 720. ddraw4.c:3716: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3726: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3731: Test failed: Expected surface width 640, got 720. ddraw4.c:3746: Test failed: Expected surface width 640, got 720. ddraw4.c:3752: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3775: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3788: Test failed: Got unexpected hr 0. ddraw4.c:3790: Test failed: Got unexpected hr 0. ddraw4.c:3797: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3802: Test failed: Expected surface width 640, got 720. ddraw4.c:3823: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3843: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3856: Test failed: Expected resolution 640x480, got 720x480. ddraw4.c:3873: Test failed: Expected surface width 640, got 720. ddraw4.c:3880: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3897: Test failed: Expected message 0x5, but didn't receive it. ddraw4.c:3899: Test failed: Expected screen size 640x480, got 0x0. ddraw4.c:3906: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3918: Test failed: Expected surface width 640, got 720. ddraw4.c:3971: Test failed: Expected screen size 2 640x480, got 720x480. ddraw4.c:3979: Test failed: Expected (0,0)-(640,480), got (0,0)-(720,480). ddraw4.c:3991: Test failed: Expected surface width 640, got 720. === debian11 (32 bit Japanese:Japan report) === ddraw: ddraw4.c:18247: Test failed: Expect clip rect (0,0)-(640,480), got (0,0)-(800,600). ddraw4.c:18271: Test failed: Expect clip rect (0,0)-(640,480), got (0,0)-(800,600). ddraw4.c:18312: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw4.c:18368: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw4.c:18375: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw4.c:18312: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,737). ddraw4.c:18334: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw4.c:18349: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw4.c:18368: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,737). ddraw4.c:18375: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,737). ddraw7.c:2616: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw7.c:2649: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw7.c:2652: Test failed: Expected window extended style 0x108, got 0x8. ddraw7.c:2658: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw7.c:2661: Test failed: Expected window extended style 0x108, got 0x8. ddraw7.c:2681: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw7.c:2683: Test failed: Expected window extended style 0x100, got 0. ddraw7.c:2700: Test failed: Expected (0,0)-(800,600), got (-32000,-32000)-(-31840,-31976). ddraw7.c:2723: Test failed: Expected (0,0)-(800,600), got (-32000,-32000)-(-31840,-31976). ddraw7.c:2743: Test failed: Expected window style 0x4cf0000, got 0xa40b0000. ddraw7.c:2745: Test failed: Expected window extended style 0x100, got 0. ddraw7.c:18586: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw7.c:18642: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw7.c:18649: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw7.c:18586: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,737). ddraw7.c:18608: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw7.c:18623: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw7.c:18642: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737). ddraw7.c:18649: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737). === debian11 (32 bit Chinese:China report) === ddraw: ddraw2.c:15297: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw2.c:15312: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw4.c:18312: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw4.c:18368: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw4.c:18375: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw4.c:18312: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,737). ddraw4.c:18334: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw4.c:18349: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw4.c:18368: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737). ddraw4.c:18375: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737). ddraw7.c:18586: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw7.c:18642: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw7.c:18649: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,768). ddraw7.c:18586: Test failed: Expect window rect (0,0)-(800,600), got (0,0)-(1024,737). ddraw7.c:18608: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw7.c:18623: Test failed: Expected window rect (800,0)-(1824,737), got (0,0)-(1024,737). ddraw7.c:18642: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737). ddraw7.c:18649: Test failed: Expect window rect (0,0)-(800,600), got (1024,0)-(2048,737). === debian11 (32 bit WoW report) === ddraw: ddraw7.c:3556: Test failed: Expected message 0x5, but didn't receive it.