From: Jinoh Kang Subject: Re: [RFC PATCH v2 03/11] include: Add a helper function to test if a status indicates deferred completion. Message-Id: <2e2219e4-6b36-aa53-1a86-7c2782408640@gmail.com> Date: Wed, 26 Jan 2022 11:27:28 +0900 In-Reply-To: References: <1e0d520b-0f60-1323-3305-4f884fb121a1@gmail.com> On 1/26/22 03:21, Zebediah Figura (she/her) wrote: > On 1/22/22 08:36, Jinoh Kang wrote: >> Put it in a separate header file so that it won't pollute everyone's >> pre-processor macro definition namespace with ntstatus.h.  Note that >> winnt.h omits STATUS_ALERTED. > > NTSTATUS values are already defined by all server files; Sorry for the confusion (I'll squash up some of the patches as you've suggested anyway). The header is used by both the server and the client; hence its placement in include/. > there's no need for a separate header. If a translation unit includes winnt.h but _not_ ntstatus.h, the compiler complains that STATUS_ALERTED is not defined. Perhaps we can just move STATUS_ALERTED into winnt.h instead? > The NTSTATUS typedef isn't, but we use "unsigned int" anyway. Server code can already use NTSTATUS, so there's no problem with it. Nevertheless, there's nothing particularly wrong here with using "unsigned int" too. -- Sincerely, Jinoh Kang