From: Giovanni Mascellani <gmascellani@codeweavers.com>
Subject: Re: [PATCH vkd3d 3/6] vkd3d-shader/hlsl: Write SM4 unsigned multiplication instructions.
Message-Id: <0b610e73-f384-50f8-8923-6edd0b6a0407@codeweavers.com>
Date: Tue, 25 Jan 2022 21:19:54 +0100
In-Reply-To: <4aa2945e-be6c-52f4-e130-94c7848f93c4@codeweavers.com>
References: <20220125110753.1358613-1-gmascellani@codeweavers.com> <20220125110753.1358613-3-gmascellani@codeweavers.com> <4aa2945e-be6c-52f4-e130-94c7848f93c4@codeweavers.com>

Hi,

Il 25/01/22 20:06, Zebediah Figura (she/her) ha scritto:
> I want to find some way to put "2 dsts" in the function name, because as 
> it is I can't tell just from reading.

Might that be "write_sm4_binary_op_with_two_destinations"?

> I'd also suggest specifying both dsts as optional hlsl_ir_node pointers, 
> where NULL translates to SM4_RT_NULL. That would allow you to use this 
> helper even if both dsts are used.

Ok, good idea. Even though in later patches I am always using just one 
result (and given how our IR is structured, I can't see how it can be 
different), but generalizing anyway doesn't seem to hurt anybody.

Giovanni.