From: Daniel Lehman Subject: [PATCH v2 1/2] msxml3/tests: Add test saving XML with non-english characters. Message-Id: Date: Tue, 25 Jan 2022 17:52:39 +0000 v2: added some Releases From 70173212ecfe852eb36ead3e280bd9e8351372e4 Mon Sep 17 00:00:00 2001 From: Daniel Lehman Date: Wed, 24 Nov 2021 08:32:29 -0800 Subject: [PATCH v2 1/2] msxml3/tests: Add test saving XML with non-english characters. Signed-off-by: Daniel Lehman --- dlls/msxml3/tests/domdoc.c | 48 +++++++++++++++++++++++++++++++++++++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index e931c683fb82..761688c187b6 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -6473,7 +6473,9 @@ static void test_put_dataType( void ) static void test_save(void) { + static const char cheA[] = ""; IXMLDOMDocument *doc, *doc2; + IXMLDOMAttribute *attr; IXMLDOMElement *root; BSTR sOrig, sNew, filename; char buffer[100]; @@ -6481,7 +6483,7 @@ static void test_save(void) HGLOBAL global; VARIANT_BOOL b; DWORD read = 0; - VARIANT dest; + VARIANT v, dest; HANDLE hfile; HRESULT hr; char *ptr; @@ -6600,6 +6602,50 @@ static void test_save(void) IStream_Release(stream); IXMLDOMDocument_Release(doc); + + /* test default encoding with non-english characters */ + doc = create_document(&IID_IXMLDOMDocument); + + hr = IXMLDOMDocument_createElement(doc, _bstr_("Testing"), &root); + EXPECT_HR(hr, S_OK); + + hr = IXMLDOMDocument_appendChild(doc, (IXMLDOMNode*)root, NULL); + EXPECT_HR(hr, S_OK); + + hr = IXMLDOMDocument_createAttribute(doc, _bstr_("che"), &attr); + EXPECT_HR(hr, S_OK); + + V_VT(&v) = VT_BSTR; + V_BSTR(&v) = SysAllocString(L"\x0427"); + hr = IXMLDOMAttribute_put_value(attr, v); + EXPECT_HR(hr, S_OK); + VariantClear(&v); + + hr = IXMLDOMElement_setAttributeNode(root, attr, NULL); + EXPECT_HR(hr, S_OK); + + V_VT(&dest) = VT_BSTR; + V_BSTR(&dest) = _bstr_("test.xml"); + + hr = IXMLDOMDocument_save(doc, dest); + EXPECT_HR(hr, S_OK); + + hfile = CreateFileA("test.xml", GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL ); + ok(hfile != INVALID_HANDLE_VALUE, "Could not open file: %u\n", GetLastError()); + if (hfile != INVALID_HANDLE_VALUE) + { + ReadFile(hfile, buffer, sizeof(buffer), &read, NULL); + ok(read != 0, "could not read file\n"); + todo_wine ok(!memcmp(buffer, cheA, sizeof(cheA)-1), "got: %s\n", buffer); + + CloseHandle(hfile); + DeleteFileA("test.xml"); + } + + IXMLDOMAttribute_Release(attr); + IXMLDOMElement_Release(root); + IXMLDOMDocument_Release(doc); + free_bstrs(); } -- 2.34.1