From: Alexandre Julliard Subject: Re: [PATCH] Use Windows 10 as default prefix version. Message-Id: <87h79t5p2w.fsf@wine> Date: Mon, 24 Jan 2022 12:51:35 +0100 In-Reply-To: (Nikolay Sivov's message of "Sat, 22 Jan 2022 20:57:09 +0300") References: <20220121142705.273101-1-nsivov@codeweavers.com> <7035e98f-ce83-b85c-a6c1-4a52db79e079@codeweavers.com> Nikolay Sivov writes: > On 1/21/22 18:11, Paul Gofman wrote: >> There is also version number in kernel32/version.rc which some games >> expect to have in sync IIRC. > > No reason we shouldn't have it in sync, but on Windows apparently it's > possible to have it slightly off comparing to build value in registry. > >> >> Then, there is a version number hardcoded in >> kernelbase/version.c:version_data[] which is currently 17134, that >> should probably be bumped as well? (fwiw there is also the number in >> ntdll/version.c: VersionData[] but this is 17763 now. > > See attached v2 patch as an attempt to unify this. Symbol name should > probably be WIN10BUILDNUMBER, in case major number will be ever bumped > from 10. > > Alexandre, what do you think? I don't think we're going to have to change it often enough to add a header just for this. Hardcoding it in a few places is fine, though I'd suggest to use decimal everywhere to make it easier to grep for. -- Alexandre Julliard julliard@winehq.org