From: "Zebediah Figura (she/her)" Subject: Re: [PATCH 4/5] winegstreamer: Register WMA decoder transform stub. Message-Id: <669bfe25-49ec-a509-b999-b6d23c9948e7@codeweavers.com> Date: Fri, 21 Jan 2022 11:23:34 -0600 In-Reply-To: References: <20220120104152.2236851-1-rbernon@codeweavers.com> <20220120104152.2236851-4-rbernon@codeweavers.com> <2d892439-0926-6669-11b6-4c6c8aa1d105@codeweavers.com> On 1/21/22 02:57, Giovanni Mascellani wrote: > Hi, > > Il 21/01/22 02:44, Zebediah Figura (she/her) ha scritto: >> Is there an application that requires this, other than FAudio? > > I don't know, but notice that Mono ships a copy of FAudio, so if we want > to patch FAudio, we have to patch that one as well. > >> And if not, can we instead try to change FAudio to not require >> specific decoders? > > Even if the current user is just FAudio, wouldn't it better to implement > properly CWMADecMediaObject anyway? This way you automatically catch all > future users of it. Why is CWMADecMediaObject something that we might > not want to implement? We will need some way to decode arbitrary data via IMFTransform objects, but it seems preferable to avoid having to implement more objects than we need. E.g. trying to catch as many as possible via a generic decoder seems like a good idea. In that case we'd want to use MFTEnum() in FAudio instead of hardcoding the CLSID.