From: "Rémi Bernon" Subject: Re: [PATCH 4/5] winegstreamer: Register WMA decoder transform stub. Message-Id: Date: Fri, 21 Jan 2022 10:05:13 +0100 In-Reply-To: References: <20220120104152.2236851-1-rbernon@codeweavers.com> <20220120104152.2236851-4-rbernon@codeweavers.com> <2d892439-0926-6669-11b6-4c6c8aa1d105@codeweavers.com> On 1/21/22 09:57, Giovanni Mascellani wrote: > Hi, > > Il 21/01/22 02:44, Zebediah Figura (she/her) ha scritto: >> Is there an application that requires this, other than FAudio? > > I don't know, but notice that Mono ships a copy of FAudio, so if we want > to patch FAudio, we have to patch that one as well. > Well, I patched FAudio to implement WMA decoding using MF and WMADecMediaObject, so sure, we can make more changes but now I think what's missing is in Wine. >> And if not, can we instead try to change FAudio to not require >> specific decoders? > > Even if the current user is just FAudio, wouldn't it better to implement > properly CWMADecMediaObject anyway? This way you automatically catch all > future users of it. Why is CWMADecMediaObject something that we might > not want to implement? > > Giovanni. > I don't think we can. XAudio / FAudio are provided raw WMA buffers and expect to be able to decode the buffer more or less synchronously. This is already implemented, and I don't see any reason to look for another way now. -- Rémi Bernon