From: "Stefan Dösinger" <stefandoesinger@gmail.com>
Subject: Re: [PATCH v7 4/6] d3d8/tests: Test for window changes when it's not foreground.
Message-Id: <2630619.fDdHjke4Dd@grey>
Date: Wed, 19 Jan 2022 23:48:17 +0300
In-Reply-To: <5cc8349d-c2df-e98d-304c-08b40f142f18@gmail.com>
References: <05381e8c5ffc4392318a3ba1c3664ac47def7e38.1642524328.git.gabrielopcode@gmail.com> <25374598.1r3eYUQgxm@grey> <5cc8349d-c2df-e98d-304c-08b40f142f18@gmail.com>

Am Mittwoch, 19. Jänner 2022, 22:51:47 EAT schrieb Gabriel Ivăncescu:

> I tested on 32-bit version of Win7 and WinXP in a VM (not real hardware,
> I don't know if it matters; I doubt it affects focus results, but at
> least the device reset works I mean).

Hmm, I think WARP was added by Windows 8. If you look at https://
testbot.winehq.org/JobDetails.pl?Key=105331&f201=exe32.report#k201 (w7u_2qxl 
testbot results for your patch) you'll see that all the tests are effectively 
skipped.

Are you sure the tests did something useful when you ran them on the Win7 and 
XP VMs?

> I also tested this on the original 64-bit Windows 10 version (1507) and
> it has the same behavior. It's always the same. No idea when it got
> changed though.

I'm happy to just drop the non-ddraw tests since the regression you are trying 
to fix is about ddraw only. The ddraw behavior is sensible in some way; d3d8, 
d3d9 and d3d9ex are all over the place though. That Win10's behavior changed 
at some point and didn't change back suggests (but doesn't prove) that there 
aren't any apps that care.

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEQxb0tqoFWyeVMl1sPRO8yFRPGiIFAmHoeREACgkQPRO8yFRP
GiLVsg/8CXriLiI0+ophtNadu4TVPxrvcjUPSNdp9rCTq34Oy+WrUxUQ3uVJ57x2
piQDDkoZQ46zeZqe6v9gVNBzFXKHC7EfMPogLsSvkBdnBVDo7dBAqnjPKiQOw+SL
a+TG4Limy1FYNsKu6JfiQ7/hmcpU/n0vGlx5dVtNVJYHjzo0NfmcksasIg4fMZPu
5WEwcuZEhH3uNRshL2DvPHfyGEt8bwg49S0IO7HFyRxF/IS+wO6BF4acp42edhDk
Sha180Fdy18uZAC/2YOLup2CnYnRMGVVqjzAEXq9Rs0sm6kwBU88WkAA79D2aarL
dEJZfGpIk0UDLryUAOCJy8mv1/4hgTV7+8IGueCTXAn27k/j97Hose/xQdLIbnV0
x+X9jyfPcs7I6/+oP/WIubhLppnnATqfZF4c4fzMEzV9UYXd3R4hpSPufuNzL3Af
/rTpHb+yjy3LcFGAUnEakrOW/hYqRdYdvKmDBub34x4qKendYD3WKnfVG7OnR585
ksmrVfJu8OOW5JM7s0csqUJauNRhAfRSr7UeXjm6MLcPC5tqbeWdhxXGndn97Wji
paNTRLYf9+Otu0BDlnLd832FzsIbBzypvJC2iC+ZQbR6Xb8yoIp/dvhFfX9KkRAj
PbRaU9IsZBdqEL3Gy6i/QPzoRzNuiiRemjDJmW+xtAAija3oUZQ=
=5GR1
-----END PGP SIGNATURE-----