From: "Rémi Bernon" <rbernon@codeweavers.com>
Subject: Re: [PATCH 05/11] include: Add windows.media.speechrecognition.idl.
Message-Id: <1b00452f-284a-ee49-c307-cdaea8b09062@codeweavers.com>
Date: Wed, 19 Jan 2022 19:24:20 +0100
In-Reply-To: <20220119132819.18340-6-besentv@gmail.com>
References: <20220119132819.18340-1-besentv@gmail.com> <20220119132819.18340-6-besentv@gmail.com>

Hi Bernhard,

On 1/19/22 14:28, Bernhard Kölbl wrote:
> +
> +namespace Windows {
> +    namespace Media {
> +        namespace SpeechRecognition {
> +            declare {
> +                interface Windows.Foundation.TypedEventHandler<Windows.Media.SpeechRecognition.SpeechContinuousRecognitionSession*, Windows.Media.SpeechRecognition.SpeechContinuousRecognitionCompletedEventArgs*>;
> +                interface Windows.Foundation.TypedEventHandler<Windows.Media.SpeechRecognition.SpeechContinuousRecognitionSession*, Windows.Media.SpeechRecognition.SpeechContinuousRecognitionResultGeneratedEventArgs*>;
> +                interface Windows.Foundation.Collections.IVector<HSTRING>;
> +                interface Windows.Foundation.Collections.IIterable<HSTRING>;
> +                interface Windows.Foundation.Collections.IIterator<HSTRING>;
> +                interface Windows.Foundation.Collections.IIterable<HSTRING>;
> +                interface Windows.Foundation.Collections.IVectorView<Windows.Media.SpeechRecognition.SpeechRecognitionResult*>;
> +                interface Windows.Foundation.Collections.IVectorView<Windows.Media.SpeechRecognition.ISpeechRecognitionConstraint*>;
> +                /* FIXME - This is broken in Widl.:
> +                interface Windows.Foundation.Collections.IVectorView<HSTRING>;
> +                interface Windows.Foundation.Collections.IMapView<HSTRING, Windows.Foundation.Collections.IVectorView<HSTRING>*>;
> +                */

Would be better to fix widl first then, I think.

Also note that for basic types we have the declare blocks in 
windows.foundation.idl in order to avoid having to declare them in every 
other idl. I'm not completely sure to remember how it's done in the 
windows sdk headers, looks like they have generated interfaces in every 
header.

Note that I haven't looked at the rest in detail, it's quite long and 
would be nice to split first. If some parts can be implemented 
progressively (even if it's just stubs) it's also probably better to 
interleave the IDL additions with some tests and implementation.
-- 
Rémi Bernon <rbernon@codeweavers.com>