From: "Rémi Bernon" <rbernon@codeweavers.com>
Subject: Re: [PATCH 01/11] include/windows.foundation.collections.idl: Add IVector<T> interface.
Message-Id: <b89f4e0a-6f94-bd36-bbc1-fc2cc6d4211a@codeweavers.com>
Date: Wed, 19 Jan 2022 19:14:58 +0100
In-Reply-To: <20220119132819.18340-2-besentv@gmail.com>
References: <20220119132819.18340-1-besentv@gmail.com> <20220119132819.18340-2-besentv@gmail.com>

Hi Bernhard,

On 1/19/22 14:28, Bernhard Kölbl wrote:
> Signed-off-by: Bernhard Kölbl <besentv@gmail.com>
> ---
>   include/windows.foundation.collections.idl | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/include/windows.foundation.collections.idl b/include/windows.foundation.collections.idl
> index 876e15336a2..d671b09e5d2 100644
> --- a/include/windows.foundation.collections.idl
> +++ b/include/windows.foundation.collections.idl
> @@ -118,6 +118,26 @@ cpp_quote("#endif")
>                   HRESULT IndexOf([in, optional] T element, [out] UINT32 *index, [out, retval] BOOLEAN *value);
>                   HRESULT GetMany([in] UINT32 start_index, [in] UINT32 items_size, [out] T *items, [out, retval] UINT32 *value);
>               }
> +
> +            [
> +                contract(Windows.Foundation.FoundationContract, 1.0),
> +                uuid(913337e9-11a1-4345-a3a2-4e7f956e222d)
> +            ]
> +            interface IVector<T> : IInspectable
> +            {
> +                HRESULT GetAt([in] UINT32 index, [out, retval] T *value);
> +                [propget] HRESULT Size([out, retval] UINT32 *value);
> +                HRESULT GetView([out, retval] IVectorView<T> **value);
> +                HRESULT IndexOf([in, optional] T element, [out] UINT32 *index, [out, retval] BOOLEAN *value);
> +                HRESULT SetAt([in] UINT32 index, [in] T value);
> +                HRESULT InsertAt([in] UINT32 index, T value);
> +                HRESULT RemoveAt([in] UINT32 index);
> +                HRESULT Append([in, optional] T value);
> +                HRESULT RemoveAtEnd();
> +                HRESULT Clear();
> +                HRESULT GetMany([in] UINT32 start_index, [in] UINT32 items_size, [out] T *items, [out, retval] UINT32 *value);
> +                HRESULT ReplaceAll([in] T *items);

You're missing the count first argument here.
-- 
Rémi Bernon <rbernon@codeweavers.com>