From: "Zebediah Figura (she/her)" <zfigura@codeweavers.com>
Subject: Re: [PATCH vkd3d 4/4] vkd3d-shader: Add support for retrieving the creator string from DXBC shaders.
Message-Id: <8cf70237-45ca-a4a4-ea49-4852e78431be@codeweavers.com>
Date: Mon, 10 Jan 2022 19:47:45 -0600
In-Reply-To: <CAOsNvwzyiDo7z+SwPK01KrB5qznk2Zwq2wLw6piHKrAxghUMZQ@mail.gmail.com>
References: <20211228222020.13814-1-zfigura@codeweavers.com> <20211228222020.13814-4-zfigura@codeweavers.com> <CAOsNvwzyiDo7z+SwPK01KrB5qznk2Zwq2wLw6piHKrAxghUMZQ@mail.gmail.com>

On 1/6/22 04:15, Henri Verbeet wrote:
> On Tue, 28 Dec 2021 at 23:20, Zebediah Figura <zfigura@codeweavers.com> wrote:
>>   struct vkd3d_shader_parser_ops
>>   {
>>       void (*parser_reset)(struct vkd3d_shader_parser *parser);
>>       void (*parser_destroy)(struct vkd3d_shader_parser *parser);
>> +    void (*parser_read_metadata)(struct vkd3d_shader_parser *parser);
>>       void (*parser_read_instruction)(struct vkd3d_shader_parser *parser, struct vkd3d_shader_instruction *instruction);
>>       bool (*parser_is_end)(struct vkd3d_shader_parser *parser);
>>   };
> 
> I don't feel strongly one way or another at this point, but should
> parser_read_metadata() perhaps just return the metadata to the caller,
> instead of storing it in the vkd3d_shader_parser structure?

I haven't written much more than these patches so far, but I think that 
makes sense.