From: "Francisco Casas" Subject: Re: [PATCH vkd3d 2/8] vkd3d-shader/hlsl: Rename replace_node() to hlsl_replace_node(). Message-Id: Date: Fri, 07 Jan 2022 12:12:37 +0000 In-Reply-To: References: <20220106173949.82958-2-fcasas@codeweavers.com> January 7, 2022 6:19 AM, "Giovanni Mascellani" wrote: > Hi, > > I think that this patch should be squashed with 1/8. The idea is that the code should be "clean" at > all times, even between the patches of a single patch set, and my understanding is that being clean > includes having a "hlsl_" prefix for all the symbols in hlsl.h (this also applies to 3/8). > > Also, I think that renaming the function and moving it to another file are changes simple enough > that they can be merged in the same patch. But if you really prefer doing that in two patches, I'd > first change the name and then move. > > Giovanni. > Okay! I have been told that's preferable to move something and change it on different patches, but maybe that is when the changes are more than just changing the name.