From: Henri Verbeet Subject: Re: [PATCH vkd3d 3/8] vkd3d-shader/hlsl: Move fold_constants() to a separate file. Message-Id: Date: Fri, 7 Jan 2022 13:01:18 +0100 In-Reply-To: <20220106173949.82958-3-fcasas@codeweavers.com> References: <20220106173949.82958-3-fcasas@codeweavers.com> On Thu, 6 Jan 2022 at 18:40, Francisco Casas wrote: > > Signed-off-by: Francisco Casas > --- > Makefile.am | 1 + > libs/vkd3d-shader/hlsl.h | 2 + > libs/vkd3d-shader/hlsl_codegen.c | 106 --------------------- > libs/vkd3d-shader/hlsl_constant_ops.c | 127 ++++++++++++++++++++++++++ > 4 files changed, 130 insertions(+), 106 deletions(-) > create mode 100644 libs/vkd3d-shader/hlsl_constant_ops.c > Is the expectation that hlsl_constant_ops.c is going to grow significantly in the future? As it is, hlsl_codegen.c isn't especially large, and could itself have been merged with hlsl.c. > +} > \ No newline at end of file > -- Well-formed C has newlines at the end of files. I know Alexandre's scripts fix these up on commit for Wine, and possibly vkd3d, but you'll nevertheless want to avoid omitting these. Typically this indicates having misconfigured your editor. (Or simply using the wrong editor. :D)