From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH vkd3d 4/4] vkd3d-shader: Add support for retrieving the creator string from DXBC shaders.
Message-Id: <CAOsNvwzyiDo7z+SwPK01KrB5qznk2Zwq2wLw6piHKrAxghUMZQ@mail.gmail.com>
Date: Thu, 6 Jan 2022 11:15:13 +0100
In-Reply-To: <20211228222020.13814-4-zfigura@codeweavers.com>
References: <20211228222020.13814-1-zfigura@codeweavers.com> <20211228222020.13814-4-zfigura@codeweavers.com>

On Tue, 28 Dec 2021 at 23:20, Zebediah Figura <zfigura@codeweavers.com> wrote:
>  struct vkd3d_shader_parser_ops
>  {
>      void (*parser_reset)(struct vkd3d_shader_parser *parser);
>      void (*parser_destroy)(struct vkd3d_shader_parser *parser);
> +    void (*parser_read_metadata)(struct vkd3d_shader_parser *parser);
>      void (*parser_read_instruction)(struct vkd3d_shader_parser *parser, struct vkd3d_shader_instruction *instruction);
>      bool (*parser_is_end)(struct vkd3d_shader_parser *parser);
>  };

I don't feel strongly one way or another at this point, but should
parser_read_metadata() perhaps just return the metadata to the caller,
instead of storing it in the vkd3d_shader_parser structure?