From: Hans Leidekker Subject: Re: [PATCH v3 2/3] msi: Disable parent dialogs while modal dialog is open Message-Id: <64fe9199d2c777329b5cb0fd71bc21f6788bbd87.camel@codeweavers.com> Date: Wed, 15 Sep 2021 14:03:42 +0200 In-Reply-To: <4010507.pNkdBLK4m9@arch> References: <20210911235700.9410-1-dark.shadow4@web.de> <9fb2e29391f1623c8c0e5e8bd2d462a236c12dc8.camel@codeweavers.com> <2983097.I70Cq16fiz@arch> <4010507.pNkdBLK4m9@arch> On Wed, 2021-09-15 at 12:45 +0200, Fabian Maurer wrote: > how does one test msi dialogs directly? Aren't they used in the msi > internally? You would need to create an installer with appropriate tables, such as Dialog, Control and ControlEvent. It may need user interaction so it would need to be interactive. A standalone test would work too. The point is that I'm not convinced that we don't need to check the msidbDialogAttributesModal attribute.