From: Hans Leidekker Subject: Re: [PATCH v3 2/3] msi: Disable parent dialogs while modal dialog is open Message-Id: <9fb2e29391f1623c8c0e5e8bd2d462a236c12dc8.camel@codeweavers.com> Date: Mon, 13 Sep 2021 13:45:32 +0200 In-Reply-To: <6067459.syKmuvjQHO@arch> References: <20210911235700.9410-1-dark.shadow4@web.de> <20210911235700.9410-2-dark.shadow4@web.de> <8ecc128cc93cb4d4982cc80b45a9c6e4035d2bdb.camel@codeweavers.com> <6067459.syKmuvjQHO@arch> On Mon, 2021-09-13 at 13:29 +0200, Fabian Maurer wrote: > > Should this be done only for dialogs with the > > msidbDialogAttributesModal > > attribute set, as suggested by the patch description? > > Can there be dialogs with a parent that are non modal? Because AFAIK > that isn't possible - at least I could not create that case Could you add a test case?