From: "Rémi Bernon" Subject: Re: [PATCH 1/4] winexinput.sys: Register known XBox controllers hardware ids. Message-Id: <6957452b-e2c0-2dca-0344-4c9be8305122@codeweavers.com> Date: Mon, 13 Sep 2021 11:24:56 +0200 In-Reply-To: <20210910071956.37887-1-rbernon@codeweavers.com> References: <20210910071956.37887-1-rbernon@codeweavers.com> I'm not completely sure to see what's wrong with these patches but I'm going to assume that it wasn't great to have a hardcoded VID&PID list from the beginning and that it would be better to use a good heuristic instead. The axis and button count heuristic should cover the XBox gamepad list, but I don't think it's good, as it will match any joystick with a lot of axes and buttons, although they may not be gamepads. It could also be interesting to have some user-facing configurable settings so we can force or prevent some devices to be seen by XInput (and use DInput instead). I'll just keep the is_xbox_gamepad helper for now, and resend something later. What I wanted to move to winexinput was actually more the custom product strings rather than this helper. -- Rémi Bernon