From: Paul Gofman <pgofman@codeweavers.com>
Subject: Re: [PATCH v1] opengl32: Fix unexpected format PIPE_FORMAT_R8G8B8_UNORM
Message-Id: <82eb77c3-8604-37e6-93e9-bb5f0d997399@codeweavers.com>
Date: Fri, 3 Sep 2021 12:18:49 +0300
In-Reply-To: <20210903050940.17326-1-shenfusheng@uniontech.com>
References: <20210903050940.17326-1-shenfusheng@uniontech.com>

Hello Shen,

    could you please elaborate a bit what exactly problem are you trying
to solve? Do you mean that there are some FB configs retrieved by
glXGetFBConfigs() corresponding to an unexpected format which should not
ever be selected? If that is the case:
    - is it documented somewhere besides the Mesa code?
    - if glXGetFBConfigs() returns an unusable format, that looks like a
Mesa bug, any reason why it is not? If there are actually some legit
hints how such formats should be sorted out, we should probably just
skip that in winex11.drv:opengl.c init_pixel_formats().

Regards,
    Paul.

On 9/3/21 08:09, Shen Fusheng wrote:
> By reading the mesa source code, a value not in the enumeration is used in the mesa code to create a rendering memory.
> It is found that the value is derived from the result of matching using wglChoosePixel, so I modified this piece by
> referring to the wglChoosePixelFormat in mesa.
>