From: Dean Greer Subject: Re: [PATCH 2/2] ntdll: Replace fstat and lstat with fstatat in get_file_info. Message-Id: Date: Mon, 30 Aug 2021 16:33:00 -0400 In-Reply-To: References: <75ec9457c4bc96bb2150421429176610@codeweavers.com> Wine was using the function for a long time but was avoided on macOS up until wine-5.8 when the old buildbot was taken out of commission. With how much of a PITA it is setting up a build environment for compiling wine on MacOSX10.8/10.9 I’d leave this as not our problem, it’s simply a matter of using the replacement library to fill in the gaps avoiding even needing a newer SDK. On Mon, Aug 30, 2021 at 4:20 PM Erich E. Hoover wrote: > On Mon, Aug 30, 2021 at 1:53 PM Dean Greer wrote: > > How badly is this function needed as there is a third-party solution > that implements this and more missing functions. > > We're currently using (even before this patch) the fstatat() function > to detect if crossing a symlink puts us on a different drive. I'd > definitely prefer for this to be "not our problem" by either using a > library to fill in these routines or upping the minimum supported Mac > OS X version. That said, it's not that hard on Mac OS X to implement > a replacement for fstatat() using fcntl(F_GETPATH). > > Best, > Erich >
Wine was using the function for a long time but was avoided on macOS up until wine-5.8 when the old buildbot was taken out of commission.

With how much of a PITA it is setting up a build environment for compiling wine on MacOSX10.8/10.9 I’d leave this as not our problem, it’s simply a matter of using the replacement library to fill in the gaps avoiding even needing a newer SDK.

On Mon, Aug 30, 2021 at 4:20 PM Erich E. Hoover <erich.e.hoover@gmail.com> wrote:
On Mon, Aug 30, 2021 at 1:53 PM Dean Greer <gcenx83@gmail.com> wrote:
> How badly is this function needed as there is a third-party solution that implements this and more missing functions.

We're currently using (even before this patch) the fstatat() function
to detect if crossing a symlink puts us on a different drive.  I'd
definitely prefer for this to be "not our problem" by either using a
library to fill in these routines or upping the minimum supported Mac
OS X version.  That said, it's not that hard on Mac OS X to implement
a replacement for fstatat() using fcntl(F_GETPATH).

Best,
Erich