From: Dean Greer Subject: Re: [PATCH 2/2] ntdll: Replace fstat and lstat with fstatat in get_file_info. Message-Id: Date: Mon, 30 Aug 2021 15:53:01 -0400 In-Reply-To: References: <75ec9457c4bc96bb2150421429176610@codeweavers.com> How badly is this function needed as there is a third-party solution that implements this and more missing functions. On Mon, Aug 30, 2021 at 3:32 PM Erich E. Hoover wrote: > On Sat, Aug 28, 2021 at 11:40 PM Chip Davis > wrote: > > August 29, 2021 12:18 AM, "Dean Greer" wrote: > > > Are you referring to a runtime issue?, since a later SDK has been > needed from wine-5.8. > > Yes. That function will be weak-linked, which means that on 10.8 and > 10.9 it will be NULL. Calling it without checking for NULL will cause a > crash on those systems. > > I was obviously expecting this to not be a problem since fstatat is > already used in fd_is_mount_point(), is there an existing example of > how we like to work around a function that's weak-linked and possibly > NULL? > > Best, > Erich >
How badly is this function needed as there is a third-party solution that implements this and more missing functions.

On Mon, Aug 30, 2021 at 3:32 PM Erich E. Hoover <erich.e.hoover@gmail.com> wrote:
On Sat, Aug 28, 2021 at 11:40 PM Chip Davis <cdavis@codeweavers.com> wrote:
> August 29, 2021 12:18 AM, "Dean Greer" <gcenx83@gmail.com> wrote:
> > Are you referring to a runtime issue?, since a later SDK has been needed from wine-5.8.
> Yes. That function will be weak-linked, which means that on 10.8 and 10.9 it will be NULL. Calling it without checking for NULL will cause a crash on those systems.

I was obviously expecting this to not be a problem since fstatat is
already used in fd_is_mount_point(), is there an existing example of
how we like to work around a function that's weak-linked and possibly
NULL?

Best,
Erich