From: Vijay Kiran Kamuju Subject: Re: [PATCH] uiautomationcore: Add stub UiaNodeFromFocus function. Message-Id: Date: Thu, 17 Jun 2021 18:59:28 +0200 In-Reply-To: <53253b05-3659-fb63-56b1-85bb318b7cca@codeweavers.com> References: <20210617101652.151809-1-infyquest@gmail.com> <53253b05-3659-fb63-56b1-85bb318b7cca@codeweavers.com> On Thu, Jun 17, 2021 at 6:22 PM Zebediah Figura (she/her) < zfigura@codeweavers.com> wrote: > On 6/17/21 5:16 AM, Vijay Kiran Kamuju wrote: > > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50576 > > > > Signed-off-by: Vijay Kiran Kamuju > > --- > > dlls/uiautomationcore/uia_main.c | 8 ++++ > > dlls/uiautomationcore/uiautomationcore.spec | 2 +- > > include/uiautomationcoreapi.h | 45 +++++++++++++++++++++ > > 3 files changed, 54 insertions(+), 1 deletion(-) > > > > diff --git a/dlls/uiautomationcore/uia_main.c > b/dlls/uiautomationcore/uia_main.c > > index 77460aa174c..49fc97748b9 100644 > > --- a/dlls/uiautomationcore/uia_main.c > > +++ b/dlls/uiautomationcore/uia_main.c > > @@ -104,3 +104,11 @@ HRESULT WINAPI UiaHostProviderFromHwnd(HWND hwnd, > IRawElementProviderSimple **pr > > FIXME("(%p, %p): stub\n", hwnd, provider); > > return E_NOTIMPL; > > } > > + > > +HRESULT WINAPI UiaNodeFromFocus(UiaCacheRequest *request, SAFEARRAY > **data, BSTR *tree) > > +{ > > + FIXME("(%p, %p, %p): stub\n", request, data, tree); > > + > > + *tree = NULL; > > + return S_OK; > > +} > > Should this also initialize *data? > Yes, it should initialize the *data to NULL. I will send a new version with some tests

On Thu, Jun 17, 2021 at 6:22 PM Zebediah Figura (she/her) <zfigura@codeweavers.com> wrote:

On 6/17/21 5:16 AM, Vijay Kiran Kamuju wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50576
>
> Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
> ---
> dlls/uiautomationcore/uia_main.c | 8 ++++
> dlls/uiautomationcore/uiautomationcore.spec | 2 +-
> include/uiautomationcoreapi.h | 45 +++++++++++++++++++++
> 3 files changed, 54 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/uiautomationcore/uia_main.c b/dlls/uiautomationcore/uia_main.c
> index 77460aa174c..49fc97748b9 100644
> --- a/dlls/uiautomationcore/uia_main.c
> +++ b/dlls/uiautomationcore/uia_main.c
> @@ -104,3 +104,11 @@ HRESULT WINAPI UiaHostProviderFromHwnd(HWND hwnd, IRawElementProviderSimple **pr
> FIXME("(%p, %p): stub\n", hwnd, provider);
> return E_NOTIMPL;
> }
> +
> +HRESULT WINAPI UiaNodeFromFocus(UiaCacheRequest *request, SAFEARRAY **data, BSTR *tree)
> +{
> + FIXME("(%p, %p, %p): stub\n", request, data, tree);
> +
> + *tree = NULL;
> + return S_OK;
> +}

Should this also initialize *data?

Yes, it should initialize the *data to NULL.

I will send a new version with some tests