From: "Conor McCarthy" <cmccarthy@codeweavers.com>
Subject: Re: [PATCH vkd3d v2 3/3] vkd3d-shader: Emit SPIR-V for descriptor arrays and arrayed bindings.
Message-Id: <4e9d0bd92cc49291e2ee3f4579e359cf@codeweavers.com>
Date: Wed, 16 Jun 2021 05:09:33 +0000
In-Reply-To: <CAOsNvwz5pk=oo2PhHJF8ty0fN_7ocS_=8CoXcjTgqxkqX00s2Q@mail.gmail.com>
References: <CAOsNvwz5pk=oo2PhHJF8ty0fN_7ocS_=8CoXcjTgqxkqX00s2Q@mail.gmail.com> <20210603050124.45254-1-cmccarthy@codeweavers.com> <20210603050124.45254-3-cmccarthy@codeweavers.com>

June 15, 2021 12:39 AM, "Henri Verbeet" <hverbeet@gmail.com> wrote:
>> - if (current->register_space != register_space || current->register_index != reg_idx)
>> + if (current->register_space != register_space || current->register_index > register_first
>> + || current->register_index + current->binding.count <= register_last)
>> continue;
> 
> I thought UAV counter descriptor arrays were unsupported?

This ensures the correct error message is returned, i.e. "Descriptor arrays are not supported" instead of "Could not find binding." It's possible to separately check register_last == register_first, but this would require yet another error message. But I should probably add register_last to the existing message.