From: Jefferson Carpenter <jeffersoncarpenter2@gmail.com>
Subject: Re: [PATCH] msxml3: Null check url in parseURL.
Message-Id: <ba6a587c-d51b-ebfd-824f-04506ac6704d@gmail.com>
Date: Tue, 15 Jun 2021 17:32:56 +0000
In-Reply-To: <41ab25ca-f9bb-3aa9-9f13-3dfa341b136a@codeweavers.com>
References: <4530cb5e-ce6d-0a97-0d9f-da919bf3409d@aoeu2code.com> <41ab25ca-f9bb-3aa9-9f13-3dfa341b136a@codeweavers.com>

On 6/15/2021 7:36 AM, Nikolay Sivov wrote:
> This is used in IVB* interface too, which is not tested.

Correct, it looks like only Invoke is tested on that interface.  It 
would be a much bigger change to add comprehensive tests for the IVB 
interface (the interface is not queried in test_saxreader).

> We might want to do the same, there is a 'version' field to account for
> that.
> 

This seems like a place to do the "right thing" instead of maintaining 
bug-for-bug compatibility - unless a program depends on the process 
crashing due to a null pointer access.