From: Matteo Bruni Subject: Re: [PATCH 2/4] d3dx10/tests: Add texture frame data to test data. Message-Id: Date: Thu, 10 Jun 2021 11:20:56 +0200 In-Reply-To: <840b4be5-623c-8b53-92fe-342cb88d8cbe@codeweavers.com> References: <840b4be5-623c-8b53-92fe-342cb88d8cbe@codeweavers.com> On Mon, Jun 7, 2021 at 8:57 AM Ziqing Hui wrote: > > > Signed-off-by: Ziqing Hui > --- > dlls/d3dx10_43/tests/d3dx10.c | 250 +++++++++++++++++++++++++--------- > 1 file changed, 186 insertions(+), 64 deletions(-) This patch basically adds a bunch of unused data. I'd simply merge it with the next patch. > static const struct test_image > { > const BYTE *data; > unsigned int size; >- D3DX10_IMAGE_INFO expected; >+ const BYTE *expected_frame; >+ D3DX10_IMAGE_INFO expected_info; > } Nitpick, I'd rather not use the term "frame", it doesn't seem to be used in this fashion in d3dx(10). Maybe a simple "expected_data" would work.