From: "Rémi Bernon" Subject: Re: [PATCH v3 6/6] ntoskrnl.exe/tests: Add some HidP_InitializeReportForID tests. Message-Id: <2ccb2cbf-dd60-ec41-2168-67b79d27a265@codeweavers.com> Date: Tue, 8 Jun 2021 22:57:54 +0200 In-Reply-To: References: <20210604091220.265735-1-rbernon@codeweavers.com> <20210604091220.265735-6-rbernon@codeweavers.com> On 6/8/21 10:50 PM, Zebediah Figura (she/her) wrote: >> +    status = HidP_InitializeReportForID(HidP_Input, 0, >> preparsed_data, report, caps.InputReportByteLength); >> +    ok(status == HIDP_STATUS_SUCCESS, "HidP_InitializeReportForID >> returned %#x\n", status); >> + >> +    memset(buffer, 0xcd, sizeof(buffer)); >> +    memset(buffer, 0, 5); >> +    buffer[0] = 0; > > This statement is redundant; is there a copy-paste error here? > I was doing some tests with report IDs, and I'm going to add tests with it, it's probably some left over code from a version with an ID which I then set to 0. I've got additional patches that will change that part again, so this patch can just be ignored and I'll make another version that better fits with the later changes. -- Rémi Bernon