From: Huw Davies Subject: Re: [PATCH v3 3/6] riched20: Use combined flags for toggling CRLF and EOP. Message-Id: <20210608063659.GA19192@merlot.physics.ox.ac.uk> Date: Tue, 8 Jun 2021 07:37:00 +0100 In-Reply-To: References: <20210529140142.29834-1-jzeng@codeweavers.com> <20210529140142.29834-3-jzeng@codeweavers.com> <20210607124745.GD18069@merlot.physics.ox.ac.uk> On Tue, Jun 08, 2021 at 01:56:09PM +0800, Jactry Zeng wrote: > Hi Huw, > On 6/7/21 8:47 PM, Huw Davies wrote: > +#define MEGT_NOOLEOBJ > 0x00000004 /* Replace OLE object mark with a space. */ > Wouldn't GT_RAWTEXT do what we want here? > I submitted more tests of EM_GETTEXTEX in https://source.winehq.org/patches/ > data/207366 . It exposed that EM_GETTEXTEX return content including OLE object > mark for most of its mode, includes GT_DEFAULT and GT_RAWTEXT. The different > between GT_DEFAULT and GT_RAWTEXT is that GT_DEFAULT doesn't includes tables > and math objects. > So we still need one more private flag likes WINE_GT_NOOLEOBJ for toggling it? Ah, right, that's "interesting". I see you actually had a test for that in [6/6]. Could you extend that test and include a table too so that we can see whether GT_DEFAULT really does strip out the table markers? (obviously that would be marked todo_wine since we don't currently add the table markers in Wine). Thanks, Huw.