From: Jactry Zeng Subject: Re: [PATCH v3 3/6] riched20: Use combined flags for toggling CRLF and EOP. Message-Id: Date: Tue, 8 Jun 2021 13:56:09 +0800 In-Reply-To: <20210607124745.GD18069@merlot.physics.ox.ac.uk> References: <20210529140142.29834-1-jzeng@codeweavers.com> <20210529140142.29834-3-jzeng@codeweavers.com> <20210607124745.GD18069@merlot.physics.ox.ac.uk> Hi Huw, On 6/7/21 8:47 PM, Huw Davies wrote: >> +#define MEGT_NOOLEOBJ 0x00000004 /* Replace OLE object mark with a space. */ > Wouldn't GT_RAWTEXT do what we want here? I submitted more tests of EM_GETTEXTEX in https://source.winehq.org/patches/data/207366 . It exposed that EM_GETTEXTEX return content including OLE object mark for most of its mode, includes GT_DEFAULT and GT_RAWTEXT. The different between GT_DEFAULT and GT_RAWTEXT is that GT_DEFAULT doesn't includes tables and math objects. So we still need one more private flag likes WINE_GT_NOOLEOBJ for toggling it?

Hi Huw,

On 6/7/21 8:47 PM, Huw Davies wrote:
+#define MEGT_NOOLEOBJ     
   0x00000004 /* Replace OLE object mark with a space. */

Wouldn't GT_RAWTEXT do what we want here?
I submitted more tests of EM_GETTEXTEX in https://source.winehq.org/patches/data/207366 . It exposed that EM_GETTEXTEX return content including OLE object mark for most of its mode, includes GT_DEFAULT and GT_RAWTEXT. The different between GT_DEFAULT and GT_RAWTEXT is that GT_DEFAULT doesn't includes tables and math objects.
So we still need one more private flag likes WINE_GT_NOOLEOBJ for toggling it?
-----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEENcHKmsHEqfZUIecDmyjwnocwYPQFAmC/BnkFAwAAAAAACgkQmyjwnocwYPT0 Ggf/bqLmC+lwmNtsUwNGB6BOJZpczA2FtYQi3UbtPOibESFZ5F4xv8MqsnIYZjefNU0wxErMfQH5 qk93XH2TzNh3vyVarlJpRcPTSK0vtad5zgv+JzLYmaJyko4MkVX4maKo/uE1PUxjiqFettVo2Y4d 9w/oHC0aKKugXGscznucQJJG/GpIWn15UuV1OP6rcoduJc9gE8KIGPDFwjv2KciGzFkE5hjOOBkb P8LlHCyyChwQHq+UmIA44/nS35VP5W+7Wxgxx5BuFbpFDUZXyFbn4jy31u/1RQTM6xKgA4HGJR6m M0LfdRu+gJjg3odIx3ZR6cVSRmaXMOM8DHpkyrK0yQ== =GlO5 -----END PGP SIGNATURE-----