From: Huw Davies <huw@codeweavers.com>
Subject: Re: [PATCH v3 5/6] riched20: Return text without OLE object mark from WM_GETTEXT.
Message-Id: <20210607125138.GE18069@merlot.physics.ox.ac.uk>
Date: Mon, 7 Jun 2021 13:51:38 +0100
In-Reply-To: <20210529140142.29834-5-jzeng@codeweavers.com>
References: <20210529140142.29834-1-jzeng@codeweavers.com> <20210529140142.29834-5-jzeng@codeweavers.com>

On Sat, May 29, 2021 at 10:01:41PM +0800, Jactry Zeng wrote:
> Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
> ---
>  dlls/riched20/editor.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c
> index 960d1401082..9d24d97d820 100644
> --- a/dlls/riched20/editor.c
> +++ b/dlls/riched20/editor.c
> @@ -2076,10 +2076,11 @@ ME_FindText(ME_TextEditor *editor, DWORD flags, const CHARRANGE *chrg, const WCH
>    return -1;
>  }
>  
> -static int ME_GetTextEx(ME_TextEditor *editor, GETTEXTEX *ex, LPARAM pText)
> +static int ME_GetTextEx(ME_TextEditor *editor, GETTEXTEX *ex, LPARAM pText, BOOL oleobj)

You shouldn't need an extra param here.  The behaviour should be toggled with GT_RAWTEXT.

It would make sense to rewrite ME_GetTextW() so that it calls ME_GetTextEx() and
not the other way around.

Huw.